Remove extension-to-component migration mechanism

chrome/browser/prefs/browser_prefs.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/browser_prefs.h"
 
 #include <string>
 
 #include "base/files/file_util.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 110 matching lines @@
 #if BUILDFLAG(ENABLE_BACKGROUND)
 #include "chrome/browser/background/background_mode_manager.h"
 #endif
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 #include "chrome/browser/accessibility/animation_policy_prefs.h"
 #include "chrome/browser/apps/shortcut_manager.h"
 #include "chrome/browser/extensions/activity_log/activity_log.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
-#include "chrome/browser/extensions/component_migration_helper.h"
 #include "chrome/browser/extensions/extension_web_ui.h"
 #include "chrome/browser/extensions/launch_util.h"
 #include "chrome/browser/signin/easy_unlock_service.h"
 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
 #include "extensions/browser/api/runtime/runtime_api.h"
 #include "extensions/browser/extension_prefs.h"
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)
 
 #if BUILDFLAG(ENABLE_PLUGIN_INSTALLATION)
@@ skipping 111 matching lines @@
 #if defined(USE_ASH)
 #include "chrome/browser/ui/ash/chrome_launcher_prefs.h"
 #endif
 
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
 #include "chrome/browser/ui/webui/md_history_ui.h"
 #endif
 
 namespace {
 
-// The SessionStartupPref used this pref to store the list of URLs to restore
-// on startup, and then renamed it to "sessions.startup_urls" in M31. Migration
-// code was added and the timestamp of when the migration happened was tracked
-// by "session.startup_urls_migration_time". Both are obsolete now (12/2015) and
-// should be removed once a few releases have happened.
-const char kURLsToRestoreOnStartupOld[] = "session.urls_to_restore_on_startup";
-const char kRestoreStartupURLsMigrationTime[] =
-  "session.startup_urls_migration_time";
-
-// Deprecated 12/2015.
-const char kRestoreOnStartupMigrated[] = "session.restore_on_startup_migrated";
-
-#if defined(USE_AURA)
-// Deprecated 1/2016.
-const char kMaxSeparationForGestureTouchesInPixels[] =
-    "gesture.max_separation_for_gesture_touches_in_pixels";
-const char kSemiLongPressTimeInMs[] = "gesture.semi_long_press_time_in_ms";
-const char kTabScrubActivationDelayInMs[] =
-    "gesture.tab_scrub_activation_delay_in_ms";
-const char kFlingMaxCancelToDownTimeInMs[] =
-    "gesture.fling_max_cancel_to_down_time_in_ms";
-const char kFlingMaxTapGapTimeInMs[] = "gesture.fling_max_tap_gap_time_in_ms";
-const char kOverscrollHorizontalThresholdComplete[] =
-    "overscroll.horizontal_threshold_complete";
-const char kOverscrollVerticalThresholdComplete[] =
-    "overscroll.vertical_threshold_complete";
-const char kOverscrollMinimumThresholdStart[] =
-    "overscroll.minimum_threshold_start";
-const char kOverscrollMinimumThresholdStartTouchpad[] =
-    "overscroll.minimum_threshold_start_touchpad";
-const char kOverscrollVerticalThresholdStart[] =
-    "overscroll.vertical_threshold_start";
-const char kOverscrollHorizontalResistThreshold[] =
-    "overscroll.horizontal_resist_threshold";
-const char kOverscrollVerticalResistThreshold[] =
-    "overscroll.vertical_resist_threshold";
-#endif  // defined(USE_AURA)
-
 #if BUILDFLAG(ENABLE_GOOGLE_NOW)
 // Deprecated 3/2016
 const char kGoogleGeolocationAccessEnabled[] =
     "googlegeolocationaccess.enabled";
 #endif
 
 // Deprecated 4/2016.
 const char kCheckDefaultBrowser[] = "browser.check_default_browser";
 
 // Deprecated 5/2016.
 const char kDesktopSearchRedirectionInfobarShownPref[] =
     "desktop_search_redirection_infobar_shown";
 
 // Deprecated 7/2016.
 const char kNetworkPredictionEnabled[] = "dns_prefetching.enabled";
 const char kDisableSpdy[] = "spdy.disabled";
 
 // Deprecated 8/2016.
 const char kRecentlySelectedEncoding[] = "profile.recently_selected_encodings";
 const char kStaticEncodings[] = "intl.static_encodings";
 
 // Deprecated 9/2016.
 const char kWebKitUsesUniversalDetector[] =
     "webkit.webprefs.uses_universal_detector";
 const char kWebKitAllowDisplayingInsecureContent[] =
     "webkit.webprefs.allow_displaying_insecure_content";
 
+#if BUILDFLAG(ENABLE_EXTENSIONS)
+// Deprecated 2/2017.
+const char kToolbarMigratedComponentActionStatus[] =
+    "toolbar_migrated_component_action_status";
+#endif
+
 void DeleteWebRTCIdentityStoreDBOnFileThread(
     const base::FilePath& profile_path) {
   base::DeleteFile(profile_path.Append(
       FILE_PATH_LITERAL("WebRTCIdentityStore")), false);
   base::DeleteFile(profile_path.Append(
       FILE_PATH_LITERAL("WebRTCIdentityStore-journal")), false);
 }
 
 void DeleteWebRTCIdentityStoreDB(const Profile& profile) {
   content::BrowserThread::PostDelayedTask(
@@ skipping 187 matching lines @@
 
   policy::URLBlacklistManager::RegisterProfilePrefs(registry);
   certificate_transparency::CTPolicyManager::RegisterPrefs(registry);
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
   EasyUnlockService::RegisterProfilePrefs(registry);
   ExtensionWebUI::RegisterProfilePrefs(registry);
   RegisterAnimationPolicyPrefs(registry);
   ToolbarActionsBar::RegisterProfilePrefs(registry);
   extensions::ActivityLog::RegisterProfilePrefs(registry);
-  extensions::ComponentMigrationHelper::RegisterPrefs(registry);
   extensions::ExtensionPrefs::RegisterProfilePrefs(registry);
   extensions::launch_util::RegisterProfilePrefs(registry);
   extensions::RuntimeAPI::RegisterPrefs(registry);
 #endif  // BUILDFLAG(ENABLE_EXTENSIONS)
 
 #if BUILDFLAG(ENABLE_EXTENSIONS) && !defined(OS_ANDROID)
   // The extension welcome notification requires a build that enables extensions
   // and notifications, and uses the UI message center.
   ExtensionWelcomeNotification::RegisterProfilePrefs(registry);
 #endif
@@ skipping 97 matching lines @@
   ash::launcher::RegisterChromeLauncherUserPrefs(registry);
 #endif
 
 #if !defined(OS_ANDROID) && !defined(OS_IOS)
   MdHistoryUI::RegisterProfilePrefs(registry);
 #endif
 
   // Preferences registered only for migration (clearing or moving to a new key)
   // go here.
 
-#if defined(USE_AURA)
-  registry->RegisterIntegerPref(kFlingMaxCancelToDownTimeInMs, 0);
-  registry->RegisterIntegerPref(kFlingMaxTapGapTimeInMs, 0);
-  registry->RegisterIntegerPref(kTabScrubActivationDelayInMs, 0);
-  registry->RegisterIntegerPref(kSemiLongPressTimeInMs, 0);
-  registry->RegisterDoublePref(kMaxSeparationForGestureTouchesInPixels, 0);
-
-  registry->RegisterDoublePref(kOverscrollHorizontalThresholdComplete, 0);
-  registry->RegisterDoublePref(kOverscrollVerticalThresholdComplete, 0);
-  registry->RegisterDoublePref(kOverscrollMinimumThresholdStart, 0);
-  registry->RegisterDoublePref(kOverscrollMinimumThresholdStartTouchpad, 0);
-  registry->RegisterDoublePref(kOverscrollVerticalThresholdStart, 0);
-  registry->RegisterDoublePref(kOverscrollHorizontalResistThreshold, 0);
-  registry->RegisterDoublePref(kOverscrollVerticalResistThreshold, 0);
-#endif  // defined(USE_AURA)
-
-  registry->RegisterListPref(kURLsToRestoreOnStartupOld);
-  registry->RegisterInt64Pref(kRestoreStartupURLsMigrationTime, 0);
-  registry->RegisterBooleanPref(kRestoreOnStartupMigrated, false);
-
 #if BUILDFLAG(ENABLE_GOOGLE_NOW)
   registry->RegisterBooleanPref(kGoogleGeolocationAccessEnabled, false);
 #endif
 
   registry->RegisterBooleanPref(kCheckDefaultBrowser, true);
 
   registry->RegisterBooleanPref(kDesktopSearchRedirectionInfobarShownPref,
                                 false);
 
   registry->RegisterBooleanPref(kNetworkPredictionEnabled, true);
   registry->RegisterBooleanPref(kDisableSpdy, false);
   registry->RegisterStringPref(kStaticEncodings, std::string());
   registry->RegisterStringPref(kRecentlySelectedEncoding, std::string());
   registry->RegisterBooleanPref(kWebKitUsesUniversalDetector, true);
 
   registry->RegisterBooleanPref(kWebKitAllowDisplayingInsecureContent, true);
+
+#if BUILDFLAG(ENABLE_EXTENSIONS)
+  registry->RegisterDictionaryPref(kToolbarMigratedComponentActionStatus);
+#endif
 }
 
 void RegisterUserProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
   RegisterProfilePrefs(registry);
 
 #if defined(OS_CHROMEOS)
   chromeos::PowerPrefs::RegisterUserProfilePrefs(registry);
 #endif
 
 #if defined(OS_ANDROID)
@@ skipping 33 matching lines @@
   const PrefService::Preference* hide_pref =
       profile_prefs->FindPreference(prefs::kHideFullscreenToolbar);
   if (!hide_pref->IsDefaultValue()) {
     bool hide_pref_value =
         profile_prefs->GetBoolean(prefs::kHideFullscreenToolbar);
     profile_prefs->SetBoolean(prefs::kShowFullscreenToolbar, !hide_pref_value);
     profile_prefs->ClearPref(prefs::kHideFullscreenToolbar);
   }
 #endif
 
-  // Added 12/1015.
-  profile_prefs->ClearPref(kURLsToRestoreOnStartupOld);
-  profile_prefs->ClearPref(kRestoreStartupURLsMigrationTime);
-
-  // Added 12/2015.
-  profile_prefs->ClearPref(kRestoreOnStartupMigrated);
-
-#if defined(USE_AURA)
-  // Added 1/2016
-  profile_prefs->ClearPref(kFlingMaxCancelToDownTimeInMs);
-  profile_prefs->ClearPref(kFlingMaxTapGapTimeInMs);
-  profile_prefs->ClearPref(kTabScrubActivationDelayInMs);
-  profile_prefs->ClearPref(kMaxSeparationForGestureTouchesInPixels);
-  profile_prefs->ClearPref(kSemiLongPressTimeInMs);
-  profile_prefs->ClearPref(kOverscrollHorizontalThresholdComplete);
-  profile_prefs->ClearPref(kOverscrollVerticalThresholdComplete);
-  profile_prefs->ClearPref(kOverscrollMinimumThresholdStart);
-  profile_prefs->ClearPref(kOverscrollMinimumThresholdStartTouchpad);
-  profile_prefs->ClearPref(kOverscrollVerticalThresholdStart);
-  profile_prefs->ClearPref(kOverscrollHorizontalResistThreshold);
-  profile_prefs->ClearPref(kOverscrollVerticalResistThreshold);
-#endif  // defined(USE_AURA)
-
 #if BUILDFLAG(ENABLE_GOOGLE_NOW)
   // Added 3/2016.
   profile_prefs->ClearPref(kGoogleGeolocationAccessEnabled);
 #endif
 
   // Added 4/2016.
   if (!profile_prefs->GetBoolean(kCheckDefaultBrowser)) {
     // Seed kDefaultBrowserLastDeclined with the install date.
     metrics::MetricsService* metrics_service =
         g_browser_process->metrics_service();
@@ skipping 14 matching lines @@
   profile_prefs->ClearPref(kNetworkPredictionEnabled);
   profile_prefs->ClearPref(kDisableSpdy);
 
   // Added 8/2016.
   profile_prefs->ClearPref(kStaticEncodings);
   profile_prefs->ClearPref(kRecentlySelectedEncoding);
 
   // Added 9/2016.
   profile_prefs->ClearPref(kWebKitUsesUniversalDetector);
   profile_prefs->ClearPref(kWebKitAllowDisplayingInsecureContent);
+
+#if BUILDFLAG(ENABLE_EXTENSIONS)
+  // Added 2/2017.
+  profile_prefs->ClearPref(kToolbarMigratedComponentActionStatus);
+#endif
 }
 
 }  // namespace chrome