Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: mojo/public/cpp/bindings/message.h

Issue 267803008: Mojo: Force folks to handle the return value of MessageReceiver::Accept{WithResponder} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_ 5 #ifndef MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
6 #define MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_ 6 #define MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
7 7
8 #include <assert.h> 8 #include <assert.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 MOJO_DISALLOW_COPY_AND_ASSIGN(Message); 76 MOJO_DISALLOW_COPY_AND_ASSIGN(Message);
77 }; 77 };
78 78
79 class MessageReceiver { 79 class MessageReceiver {
80 public: 80 public:
81 virtual ~MessageReceiver() {} 81 virtual ~MessageReceiver() {}
82 82
83 // The receiver may mutate the given message. Returns true if the message 83 // The receiver may mutate the given message. Returns true if the message
84 // was accepted and false otherwise, indicating that the message was invalid 84 // was accepted and false otherwise, indicating that the message was invalid
85 // or malformed. 85 // or malformed.
86 virtual bool Accept(Message* message) = 0; 86 virtual bool Accept(Message* message) MOJO_WARN_UNUSED_RESULT = 0;
87 87
88 // A variant on Accept that registers a MessageReceiver (known as the 88 // A variant on Accept that registers a MessageReceiver (known as the
89 // responder) to handle the response message generated from the given 89 // responder) to handle the response message generated from the given
90 // message. The responder's Accept method may be called during 90 // message. The responder's Accept method may be called during
91 // AcceptWithResponder or some time after its return. 91 // AcceptWithResponder or some time after its return.
92 // 92 //
93 // NOTE: Upon returning true, AcceptWithResponder assumes ownership of 93 // NOTE: Upon returning true, AcceptWithResponder assumes ownership of
94 // |responder| and will delete it after calling |responder->Accept| or upon 94 // |responder| and will delete it after calling |responder->Accept| or upon
95 // its own destruction. 95 // its own destruction.
96 // 96 //
97 virtual bool AcceptWithResponder(Message* message, 97 virtual bool AcceptWithResponder(
98 MessageReceiver* responder) = 0; 98 Message* message, MessageReceiver* responder) MOJO_WARN_UNUSED_RESULT = 0;
99 }; 99 };
100 100
101 // Read a single message from the pipe and dispatch to the given receiver. The 101 // Read a single message from the pipe and dispatch to the given receiver. The
102 // receiver may be null, in which case the message is simply discarded. 102 // receiver may be null, in which case the message is simply discarded.
103 // Returns MOJO_RESULT_SHOULD_WAIT if the caller should wait on the handle to 103 // Returns MOJO_RESULT_SHOULD_WAIT if the caller should wait on the handle to
104 // become readable. Returns MOJO_RESULT_OK if a message was dispatched and 104 // become readable. Returns MOJO_RESULT_OK if a message was dispatched and
105 // otherwise returns an error code if something went wrong. 105 // otherwise returns an error code if something went wrong.
106 MojoResult ReadAndDispatchMessage(MessagePipeHandle handle, 106 MojoResult ReadAndDispatchMessage(MessagePipeHandle handle,
107 MessageReceiver* receiver, 107 MessageReceiver* receiver,
108 bool* receiver_result); 108 bool* receiver_result);
109 109
110 } // namespace mojo 110 } // namespace mojo
111 111
112 #endif // MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_ 112 #endif // MOJO_PUBLIC_CPP_BINDINGS_MESSAGE_H_
OLDNEW
« no previous file with comments | « no previous file | mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698