Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 267803008: Mojo: Force folks to handle the return value of MessageReceiver::Accept{WithResponder} (Closed)

Created:
6 years, 7 months ago by darin (slow to review)
Modified:
6 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Force folks to handle the return value of MessageReceiver::Accept{WithResponder} Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268013

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M mojo/public/cpp/bindings/message.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
darin (slow to review)
6 years, 7 months ago (2014-05-02 22:21:58 UTC) #1
viettrungluu
lgtm
6 years, 7 months ago (2014-05-02 22:24:26 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-02 22:58:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/267803008/20001
6 years, 7 months ago (2014-05-02 22:58:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-03 00:42:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-03 00:42:17 UTC) #6
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 7 months ago (2014-05-03 01:44:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/267803008/20001
6 years, 7 months ago (2014-05-03 01:44:28 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 02:34:27 UTC) #9
Message was sent while issue was closed.
Change committed as 268013

Powered by Google App Engine
This is Rietveld 408576698