Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 267803007: Add checks for READMEs for each virtual test suite. (Closed)

Created:
6 years, 7 months ago by Dirk Pranke
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews
Visibility:
Public.

Description

Add checks for READMEs for each virtual test suite. By convention, each virtual test suite should have a README.txt documenting what directory it mirrors and what command line args are needed, so that you can tell what an "empty" directory under LayoutTests/ is for. This patch modifies lint-test-expectations to check that those READMEs exist, and will help avoid the possibility that we'll delete whole directories thinking they are unneeded and introduce weird errors when TestExpectations still refer to nonexistent directories or files. R=ojan@chromium.org BUG=369385 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175748

Patch Set 1 #

Patch Set 2 : remove spurious change to NeverFixTests #

Patch Set 3 : add missing READMEs, fix web-animation-api virtual suite #

Patch Set 4 : clean up, add unit tests, merge to HEAD #

Patch Set 5 : remove virtual http tests #

Patch Set 6 : merge to r175714 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -83 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
A + LayoutTests/virtual/android/fullscreen/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/antialiasedtext/fast/text/README.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/deferred/inspector/timeline/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/implsidepainting/inspector/timeline/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/linux-subpixel/platform/linux/fast/text/subpixel/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/mac-antialiasedtext/fast/text/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/serviceworker/http/tests/serviceworker/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/stable/animations-unprefixed/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/stable/fast/css3-text/css3-text-decoration/stable/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/stable/media/stable/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/stable/web-animations-api/README.txt View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/virtual/stable/webexposed/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/targetedstylerecalc/fast/css/invalidation/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/threaded/animations/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/threaded/transitions/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/virtual/windows-directwrite/fast/text/README.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py View 1 2 3 2 chunks +65 lines, -34 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py View 1 2 3 4 chunks +72 lines, -32 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (0 generated)
Dirk Pranke
6 years, 7 months ago (2014-05-02 23:36:36 UTC) #1
Dirk Pranke
ping?
6 years, 7 months ago (2014-05-05 21:15:40 UTC) #2
ojan
lgtm
6 years, 7 months ago (2014-05-07 02:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/267803007/20001
6 years, 7 months ago (2014-05-07 02:00:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 02:30:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 02:49:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 03:03:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink
6 years, 7 months ago (2014-05-07 03:03:10 UTC) #8
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-03 23:23:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/267803007/40001
6 years, 6 months ago (2014-06-03 23:23:31 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 01:48:52 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 01:58:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10182)
6 years, 6 months ago (2014-06-04 01:58:49 UTC) #13
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-06 00:47:10 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/267803007/80001
6 years, 6 months ago (2014-06-06 00:51:03 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-06 01:52:34 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 02:08:23 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10518)
6 years, 6 months ago (2014-06-06 02:08:23 UTC) #18
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-06 22:52:55 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/267803007/100001
6 years, 6 months ago (2014-06-06 22:54:02 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-06 23:43:32 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 23:52:03 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10703)
6 years, 6 months ago (2014-06-06 23:52:04 UTC) #23
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 6 months ago (2014-06-07 16:42:03 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/267803007/100001
6 years, 6 months ago (2014-06-07 16:43:00 UTC) #25
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 17:45:35 UTC) #26
Message was sent while issue was closed.
Change committed as 175748

Powered by Google App Engine
This is Rietveld 408576698