Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: net/quic/core/quic_session_test.cc

Issue 2678003003: Make QUIC force HOL-blocking mode only apply to v36. This is basically a no-op since neither v36 no… (Closed)
Patch Set: fix two chromium tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | net/quic/core/quic_spdy_session.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/quic_session.h" 5 #include "net/quic/core/quic_session.h"
6 6
7 #include <cstdint> 7 #include <cstdint>
8 #include <set> 8 #include <set>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 1202 matching lines...) Expand 10 before | Expand all | Expand 10 after
1213 session_.max_open_incoming_streams()); 1213 session_.max_open_incoming_streams());
1214 EXPECT_EQ(session_.max_open_outgoing_streams(), 1214 EXPECT_EQ(session_.max_open_outgoing_streams(),
1215 kDefaultMaxStreamsPerConnection); 1215 kDefaultMaxStreamsPerConnection);
1216 EXPECT_GT(session_.max_open_incoming_streams(), 1216 EXPECT_GT(session_.max_open_incoming_streams(),
1217 kDefaultMaxStreamsPerConnection); 1217 kDefaultMaxStreamsPerConnection);
1218 } 1218 }
1219 1219
1220 TEST_P(QuicSessionTestServer, EnableFHOLThroughConfigOption) { 1220 TEST_P(QuicSessionTestServer, EnableFHOLThroughConfigOption) {
1221 QuicConfigPeer::SetReceivedForceHolBlocking(session_.config()); 1221 QuicConfigPeer::SetReceivedForceHolBlocking(session_.config());
1222 session_.OnConfigNegotiated(); 1222 session_.OnConfigNegotiated();
1223 if (version() <= QUIC_VERSION_35) { 1223 if (version() != QUIC_VERSION_36) {
1224 EXPECT_FALSE(session_.force_hol_blocking()); 1224 EXPECT_FALSE(session_.force_hol_blocking());
1225 } else { 1225 } else {
1226 EXPECT_TRUE(session_.force_hol_blocking()); 1226 EXPECT_TRUE(session_.force_hol_blocking());
1227 } 1227 }
1228 } 1228 }
1229 1229
1230 class QuicSessionTestClient : public QuicSessionTestBase { 1230 class QuicSessionTestClient : public QuicSessionTestBase {
1231 protected: 1231 protected:
1232 QuicSessionTestClient() : QuicSessionTestBase(Perspective::IS_CLIENT) {} 1232 QuicSessionTestClient() : QuicSessionTestBase(Perspective::IS_CLIENT) {}
1233 }; 1233 };
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
1298 QuicConfigPeer::SetConnectionOptionsToSend(session_.config(), copt); 1298 QuicConfigPeer::SetConnectionOptionsToSend(session_.config(), copt);
1299 session_.OnConfigNegotiated(); 1299 session_.OnConfigNegotiated();
1300 EXPECT_EQ( 1300 EXPECT_EQ(
1301 QuicSpdySessionPeer::GetSpdyFramer(&session_).header_encoder_table_size(), 1301 QuicSpdySessionPeer::GetSpdyFramer(&session_).header_encoder_table_size(),
1302 0UL); 1302 0UL);
1303 } 1303 }
1304 1304
1305 TEST_P(QuicSessionTestClient, EnableFHOLThroughConfigOption) { 1305 TEST_P(QuicSessionTestClient, EnableFHOLThroughConfigOption) {
1306 session_.config()->SetForceHolBlocking(); 1306 session_.config()->SetForceHolBlocking();
1307 session_.OnConfigNegotiated(); 1307 session_.OnConfigNegotiated();
1308 if (version() <= QUIC_VERSION_35) { 1308 if (version() != QUIC_VERSION_36) {
1309 EXPECT_FALSE(session_.force_hol_blocking()); 1309 EXPECT_FALSE(session_.force_hol_blocking());
1310 } else { 1310 } else {
1311 EXPECT_TRUE(session_.force_hol_blocking()); 1311 EXPECT_TRUE(session_.force_hol_blocking());
1312 } 1312 }
1313 } 1313 }
1314 1314
1315 } // namespace 1315 } // namespace
1316 } // namespace test 1316 } // namespace test
1317 } // namespace net 1317 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_stream_factory_test.cc ('k') | net/quic/core/quic_spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698