Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2677993002: Use IOSImageDataFetcherWrapper for favicon (Closed)
Patch Set: Add header Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 830c37820422ddaea14e7ed23db9deca4b86ee3a..9cf5af4e4d4de2f550d656c895d4d4d87712c831 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -3049,7 +3049,9 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
DCHECK(url.is_valid());
base::WeakNSObject<BrowserViewController> weakSelf(self);
const GURL image_source_url = url;
- image_fetcher::IOSImageDataFetcherCallback callback = ^(NSData* data) {
+ image_fetcher::IOSImageDataFetcherCallback callback = ^(
+ NSData* data, const int response_code) {
+
DCHECK(data);
dispatch_async(dispatch_get_main_queue(), ^{
[weakSelf searchByImageData:data atURL:image_source_url];
@@ -3105,11 +3107,12 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
referrer:(const web::Referrer&)referrer {
DCHECK(url.is_valid());
- image_fetcher::IOSImageDataFetcherCallback callback = ^(NSData* data) {
- DCHECK(data);
+ image_fetcher::IOSImageDataFetcherCallback callback =
+ ^(NSData* data, const int response_code) {
+ DCHECK(data);
- [self managePermissionAndSaveImage:data];
- };
+ [self managePermissionAndSaveImage:data];
+ };
_imageFetcher->FetchImageDataWebpDecoded(
url, callback, web::ReferrerHeaderValueForNavigation(url, referrer),
web::PolicyForNavigation(url, referrer));

Powered by Google App Engine
This is Rietveld 408576698