Use IOSImageDataFetcherWrapper for favicon

components/favicon/ios/web_favicon_driver.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_FAVICON_IOS_WEB_FAVICON_DRIVER_H_
 #define COMPONENTS_FAVICON_IOS_WEB_FAVICON_DRIVER_H_
 
 #include "base/macros.h"
 #include "components/favicon/core/favicon_driver_impl.h"
+#import "components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h"

[mef, 2017/02/06 16:36:17]

is this #import needed here if you forward declare it below?

[sdefresne, 2017/02/06 17:33:33]

I think the import is required as the image_fetcher_ field is not a pointer (so
the full type need to be known). The forward-declaration is redundant.

[gambard, 2017/02/07 10:03:33]

Yes, sorry.

 #include "ios/web/public/web_state/web_state_observer.h"
 #include "ios/web/public/web_state/web_state_user_data.h"
 
+namespace image_fetcher {
+class IOSImageDataFetcherWrapper;

[sdefresne, 2017/02/06 17:33:33]

Remove.

[gambard, 2017/02/07 10:03:33]

Done.

+}
+
 namespace web {
 class WebState;
 }
 
 namespace favicon {
 
 // WebFaviconDriver is an implementation of FaviconDriver that listen to
 // WebState events to start download of favicons and to get informed when the
 // favicon download has completed.
 class WebFaviconDriver : public web::WebStateObserver,
@@ skipping 28 matching lines @@
                    bookmarks::BookmarkModel* bookmark_model);
   ~WebFaviconDriver() override;
 
   // web::WebStateObserver implementation.
   void FaviconUrlUpdated(
       const std::vector<web::FaviconURL>& candidates) override;
 
   // The URL passed to FetchFavicon().
   GURL fetch_favicon_url_;
 
+  // Image Fetcher used to fetch favicon.
+  image_fetcher::IOSImageDataFetcherWrapper image_fetcher_;
+
   DISALLOW_COPY_AND_ASSIGN(WebFaviconDriver);
 };
 
 }  // namespace favicon
 
 #endif  // COMPONENTS_FAVICON_IOS_WEB_FAVICON_DRIVER_H_