Use IOSImageDataFetcherWrapper for favicon

components/image_fetcher/image_data_fetcher.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_IMAGE_FETCHER_IMAGE_DATA_FETCHER_H_
 #define COMPONENTS_IMAGE_FETCHER_IMAGE_DATA_FETCHER_H_
 
 #include <map>
 #include <memory>
 #include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
+#include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request.h"
 #include "url/gurl.h"
 
 namespace net {
 class URLFetcher;
 class URLRequestContextGetter;
 }  // namespace net
 
 namespace image_fetcher {
 
 class ImageDataFetcher : public net::URLFetcherDelegate {
  public:
+  // Imposible http response code. Used to signal that no http response code

[Marc Treib, 2017/02/07 10:10:21]

nit: Impossible

[sdefresne, 2017/02/07 10:18:30]

Imposible -> Impossible

[gambard, 2017/02/08 14:48:12]

Done.

+  // was received.
+  enum ResponseCode {
+    RESPONSE_CODE_INVALID = net::URLFetcher::RESPONSE_CODE_INVALID

[Marc Treib, 2017/02/07 10:10:21]

Hm, I'm not entirely convinced we want this alias. As far as I can tell, it's
currently not used anywhere, and anyway clients could just compare to
net::URLFetcher::RESPONSE_CODE_INVALID directly. (That's a bit ugly since it
kinda exposes implementation details of URLFetcher, but then the whole fake
response code is a bit of a hack, so...)

tl;dr I'd remove the alias, and mention net::URLFetcher::RESPONSE_CODE_INVALID
in the comment below. WDYT?

[Marc Treib, 2017/02/07 10:23:14]

As discussed out-of-band: I'm okay with the alias.

[gambard, 2017/02/08 14:48:12]

Acknowledged.

+  };
+
+  // Callback with the |image_data| and the |http_response_code|. If an error
+  // prevented a http response, |http_response_code| will be
+  // RESPONSE_CODE_INVALID.
   using ImageDataFetcherCallback =
-      base::Callback<void(const std::string& image_data)>;
+      base::Callback<void(const std::string& image_data,
+                          int http_response_code)>;
 
   using DataUseServiceName = data_use_measurement::DataUseUserData::ServiceName;
 
   explicit ImageDataFetcher(
       net::URLRequestContextGetter* url_request_context_getter);
   ~ImageDataFetcher() override;
 
   // Sets a service name against which to track data usage.
   void SetDataUseServiceName(DataUseServiceName data_use_service_name);
 
@@ skipping 29 matching lines @@
   // get individual URLFetchers and modify their state. Outside of tests this ID
   // is not used.
   int next_url_fetcher_id_;
 
   DISALLOW_COPY_AND_ASSIGN(ImageDataFetcher);
 };
 
 }  // namespace image_fetcher
 
 #endif  // COMPONENTS_IMAGE_FETCHER_IMAGE_DATA_FETCHER_H_