components/favicon/ios/DEPS - Issue 2677993002: Use IOSImageDataFetcherWrapper for favicon

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon/ios/DEPS

Issue 2677993002: Use IOSImageDataFetcherWrapper for favicon (Closed)

Patch Set: Add header Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+components/image_fetcher/ios",

2 "+ios/web/public",	3 "+ios/web/public",

	4 "+skia/ext/skia_utils_ios.h",
	sdefresne 2017/02/07 10:18:30 Please add the following above the rules for skia Please add the following above the rules for skia includes (taken from ios/chrome/DEPS): # Only parts of skia are compiled on iOS, so we explicitly list the # files that can be included to avoid bringing in more code. "+skia/ext/skia_utils_ios.h", "+third_party/skia/include/core/SkBitmap.h", gambard 2017/02/08 14:48:12 Done. Show quoted text On 2017/02/07 10:18:30, sdefresne wrote: > Please add the following above the rules for skia includes (taken from > ios/chrome/DEPS): > > # Only parts of skia are compiled on iOS, so we explicitly list the > # files that can be included to avoid bringing in more code. > "+skia/ext/skia_utils_ios.h", > "+third_party/skia/include/core/SkBitmap.h", Done.
	5 "+third_party/skia/include/core/SkBitmap.h",

3 ]	6 ]

OLD	NEW