Issue 267793006: save-draw*-restore -> noop-draw*-noop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267793006: save-draw-restore -> noop-draw-noop (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
mtklein, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

save-draw*-restore -> noop-draw*-noop save-drawA-drawB-drawC-restore always means drawA-drawB-drawC, no matter what flags we use for save(). This one triggers all over the silk SKPs and in several of the bot SKPs, typically as save-drawBitmap-restore. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14618

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -12 lines)			Patch
	M	src/record/SkRecordOpts.cpp	View	1 2	2 chunks	+19 lines, -3 lines	0 comments	Download
	M	tests/RecordOptsTest.cpp	View	1 2	2 chunks	+22 lines, -9 lines	0 comments	Download