Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: content/renderer/media/media_stream_audio_processor.cc

Issue 2677893002: Adding functionality for activating for the WebRTC EchoCanceller3 functionality in Chrome. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_audio_processor.cc
diff --git a/content/renderer/media/media_stream_audio_processor.cc b/content/renderer/media/media_stream_audio_processor.cc
index 6f7afe612a4a9d74c9cf555243ed1840be176828..d45605eb18bc3f5b8f08126a73fb4f5c13be6196 100644
--- a/content/renderer/media/media_stream_audio_processor.cc
+++ b/content/renderer/media/media_stream_audio_processor.cc
@@ -580,6 +580,11 @@ void MediaStreamAudioProcessor::GetStats(AudioProcessorStats* stats) {
GetAudioProcessingStats(audio_processing_.get(), stats);
}
+// Features for http://crbug.com/688388. This value is sent to WebRTC's echo
hlundin-chromium 2017/02/09 10:20:45 Move this information to content_features.{h|cc}.
peah 2017/02/15 13:24:24 Done.
+// canceller to toggle which echo canceller should be used.
+const base::Feature kUseEchoCanceller3{"UseEchoCanceller3",
hlundin-chromium 2017/02/09 10:20:45 You are defining this feature twice: here and in c
peah 2017/02/15 13:24:24 Thanks! Great suggestion! Done.
+ base::FEATURE_DISABLED_BY_DEFAULT};
+
void MediaStreamAudioProcessor::InitializeAudioProcessingModule(
const blink::WebMediaConstraints& constraints,
const MediaStreamDevice::AudioDeviceParameters& input_params) {
@@ -676,6 +681,11 @@ void MediaStreamAudioProcessor::InitializeAudioProcessingModule(
// Prepare for logging echo information. If there are data remaining in
// |echo_information_| we simply discard it.
echo_information_.reset(new EchoInformation());
+
+ apm_config.echo_canceller3.enabled =
+ base::FeatureList::IsEnabled(kUseEchoCanceller3);
+ } else {
+ apm_config.echo_canceller3.enabled = false;
}
if (goog_ns) {

Powered by Google App Engine
This is Rietveld 408576698