Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: chrome/browser/about_flags.cc

Issue 2677893002: Adding functionality for activating for the WebRTC EchoCanceller3 functionality in Chrome. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 4fd3c68be996609d0ccc1711aa0591949014b47f..2d8b02a7a527cc953cd65d56d7ee2c931527161b 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -749,6 +749,9 @@ const FeatureEntry kFeatureEntries[] = {
{"enable-webrtc-stun-origin", IDS_FLAGS_WEBRTC_STUN_ORIGIN_NAME,
IDS_FLAGS_WEBRTC_STUN_ORIGIN_DESCRIPTION, kOsAll,
SINGLE_VALUE_TYPE(switches::kEnableWebRtcStunOrigin)},
+ {"enable-webrtc-echo-canceller3", IDS_FLAGS_WEBRTC_ECHO_CANCELLER_3_NAME,
+ IDS_FLAGS_WEBRTC_ECHO_CANCELLER_3_DESCRIPTION, kOsAll,
+ FEATURE_VALUE_TYPE(features::kUseEchoCanceller3)},
#endif // ENABLE_WEBRTC
#if defined(OS_ANDROID)
{"enable-osk-overscroll", IDS_FLAGS_ENABLE_OSK_OVERSCROLL_NAME,
@@ -1849,10 +1852,9 @@ const FeatureEntry kFeatureEntries[] = {
ntp_snippets::kStudyName)},
{"override-ntp-suggestions-source", IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_NAME,
IDS_FLAGS_OVERRIDE_SNIPPETS_SOURCE_DESCRIPTION, kOsAndroid,
- FEATURE_WITH_VARIATIONS_VALUE_TYPE(
hlundin-chromium 2017/02/09 10:20:45 I think you should avoid changing the formatting f
peah 2017/02/15 13:24:24 Thanks! Done.
- ntp_snippets::kContentSuggestionsSource,
- kNTPSnippetsFeatureVariations,
- ntp_snippets::kStudyName)},
+ FEATURE_WITH_VARIATIONS_VALUE_TYPE(ntp_snippets::kContentSuggestionsSource,
+ kNTPSnippetsFeatureVariations,
+ ntp_snippets::kStudyName)},
{"enable-ntp-snippets-increased-visibility",
IDS_FLAGS_ENABLE_NTP_SNIPPETS_VISIBILITY_NAME,
IDS_FLAGS_ENABLE_NTP_SNIPPETS_VISIBILITY_DESCRIPTION, kOsAndroid,
@@ -2206,8 +2208,8 @@ const FeatureEntry kFeatureEntries[] = {
#if defined(OS_CHROMEOS)
{"show-arc-files-app", IDS_FLAGS_SHOW_ARC_FILES_APP_NAME,
- IDS_FLAGS_SHOW_ARC_FILES_APP_DESCRIPTION, kOsCrOS,
hlundin-chromium 2017/02/09 10:20:45 Same here. Don't change format.
peah 2017/02/15 13:24:24 Thanks! Done.
- FEATURE_VALUE_TYPE(arc::kShowArcFilesAppFeature)},
+ IDS_FLAGS_SHOW_ARC_FILES_APP_DESCRIPTION, kOsCrOS,
+ FEATURE_VALUE_TYPE(arc::kShowArcFilesAppFeature)},
#endif // defined(OS_CHROMEOS)
// NOTE: Adding new command-line switches requires adding corresponding

Powered by Google App Engine
This is Rietveld 408576698