Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: extensions/browser/extension_web_contents_observer.h

Issue 2677873002: Convert ExtensionWebContentsObserver to use the new navigation callbacks. (Closed)
Patch Set: review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/browser/extension_web_contents_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_EXTENSION_WEB_CONTENTS_OBSERVER_H_ 5 #ifndef EXTENSIONS_BROWSER_EXTENSION_WEB_CONTENTS_OBSERVER_H_
6 #define EXTENSIONS_BROWSER_EXTENSION_WEB_CONTENTS_OBSERVER_H_ 6 #define EXTENSIONS_BROWSER_EXTENSION_WEB_CONTENTS_OBSERVER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 // content::WebContentsObserver overrides. 82 // content::WebContentsObserver overrides.
83 83
84 // A subclass should invoke this method to finish extension process setup. 84 // A subclass should invoke this method to finish extension process setup.
85 void RenderViewCreated(content::RenderViewHost* render_view_host) override; 85 void RenderViewCreated(content::RenderViewHost* render_view_host) override;
86 86
87 void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override; 87 void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
88 void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override; 88 void RenderFrameDeleted(content::RenderFrameHost* render_frame_host) override;
89 void DidFinishNavigation( 89 void DidFinishNavigation(
90 content::NavigationHandle* navigation_handle) override; 90 content::NavigationHandle* navigation_handle) override;
91 void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host,
92 const content::LoadCommittedDetails& details,
93 const content::FrameNavigateParams& params) override;
94 91
95 // Subclasses should call this first before doing their own message handling. 92 // Subclasses should call this first before doing their own message handling.
96 bool OnMessageReceived(const IPC::Message& message, 93 bool OnMessageReceived(const IPC::Message& message,
97 content::RenderFrameHost* render_frame_host) override; 94 content::RenderFrameHost* render_frame_host) override;
98 95
99 // Per the documentation in WebContentsObserver, these two methods are invoked 96 // Per the documentation in WebContentsObserver, these two methods are invoked
100 // when a Pepper plugin instance is attached/detached in the page DOM. 97 // when a Pepper plugin instance is attached/detached in the page DOM.
101 void PepperInstanceCreated() override; 98 void PepperInstanceCreated() override;
102 void PepperInstanceDeleted() override; 99 void PepperInstanceDeleted() override;
103 100
(...skipping 23 matching lines...) Expand all
127 content::BrowserContext* browser_context_; 124 content::BrowserContext* browser_context_;
128 125
129 ExtensionFunctionDispatcher dispatcher_; 126 ExtensionFunctionDispatcher dispatcher_;
130 127
131 DISALLOW_COPY_AND_ASSIGN(ExtensionWebContentsObserver); 128 DISALLOW_COPY_AND_ASSIGN(ExtensionWebContentsObserver);
132 }; 129 };
133 130
134 } // namespace extensions 131 } // namespace extensions
135 132
136 #endif // EXTENSIONS_BROWSER_EXTENSION_WEB_CONTENTS_OBSERVER_H_ 133 #endif // EXTENSIONS_BROWSER_EXTENSION_WEB_CONTENTS_OBSERVER_H_
OLDNEW
« no previous file with comments | « no previous file | extensions/browser/extension_web_contents_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698