pkg/analysis_server/lib/src/services/search/search_engine_internal.dart - Issue 2677833002: Don't search for 'declaration' of elements, just name is usually enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/search/search_engine_internal.dart

Issue 2677833002: Don't search for 'declaration' of elements, just name is usually enough. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart ('k') | pkg/analyzer/lib/src/dart/analysis/ast_provider_driver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/search/search_engine_internal.dart

diff --git a/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart b/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart

index 78fbb0f1b4536a5244a4ca35c30b7b8e2c8b0cb7..83d968f77f39fba3b8cf86874a9c1e59703bf743 100644

--- a/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart

+++ b/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart

@@ -262,8 +262,8 @@ class SearchEngineImpl implements SearchEngine {

Element element, bool isRootNode(AstNode n)) async {

_LocalReferencesVisitor visitor = new _LocalReferencesVisitor(element);

AstProvider astProvider = _getAstProvider(element.source.fullName);

- AstNode node = await astProvider.getResolvedNodeForElement(element);

- AstNode enclosingNode = node?.getAncestor(isRootNode);

+ AstNode name = await astProvider.getResolvedNameForElement(element);

+ AstNode enclosingNode = name?.getAncestor(isRootNode);

enclosingNode?.accept(visitor);

return visitor.matches;

}