pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart - Issue 2677833002: Don't search for 'declaration' of elements, just name is usually enough.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

Issue 2677833002: Don't search for 'declaration' of elements, just name is usually enough. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/inline_local.dart ('k') | pkg/analysis_server/lib/src/services/search/search_engine_internal.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

index cf6c2799663d1da165fa30dd4083d97a70d612ed..e23c60c1d32613d8207cedd976ab135b61751ffa 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart

@@ -112,8 +112,8 @@ class RenameConstructorRefactoringImpl extends RenameRefactoringImpl {

Future<Null> _replaceSynthetic() async {

ClassElement classElement = element.enclosingElement;

- ClassDeclaration classNode =

- await astProvider.getResolvedNodeForElement(classElement);

+ AstNode name = await astProvider.getResolvedNameForElement(classElement);

+ ClassDeclaration classNode = name.parent as ClassDeclaration;

CorrectionUtils utils = new CorrectionUtils(classNode.parent);

ClassMemberLocation location =

utils.prepareNewConstructorLocation(classNode);