Refactoring the way begin frame sources inside scheduler work.

cc/output/begin_frame_args.h

Index: cc/output/begin_frame_args.h
diff --git a/cc/output/begin_frame_args.h b/cc/output/begin_frame_args.h
index b23a81e183a2180a90684cf92736d59ba3ba5804..78201655af694132fe9e7ce042c95154c69c27fe 100644
--- a/cc/output/begin_frame_args.h
+++ b/cc/output/begin_frame_args.h
@@ -20,6 +20,13 @@ class TracedValue;
 namespace cc {
 
 struct CC_EXPORT BeginFrameArgs {
+  enum BeginFrameArgsType {
+    INVALID,
+    NORMAL,
+    SYNCHRONOUS,
+    MISSED,
+  };
+
   // Creates an invalid set of values.
   BeginFrameArgs();
 
@@ -27,7 +34,8 @@ struct CC_EXPORT BeginFrameArgs {
   // created by searching for "BeginFrameArgs::Create".
   static BeginFrameArgs Create(base::TimeTicks frame_time,
                                base::TimeTicks deadline,
-                               base::TimeDelta interval);
+                               base::TimeDelta interval,
+                               BeginFrameArgsType type = NORMAL);

[brianderson, 2014/09/27 00:41:40]

Default values aren't allowed, but overloading is. Please make this a separate
function.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Default_Argum...

[danakj, 2014/09/27 01:09:44]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Over...

But if you're going to overload consider making the name slightly different is
the advice of the guide, which I think really helps.

[mithro-old, 2014/09/30 08:30:01]

Someone should fix CreateForSynchronousCompositor below.

[mithro-old, 2014/09/30 08:30:01]

Done.

   static BeginFrameArgs CreateForSynchronousCompositor(
       base::TimeTicks now = base::TimeTicks());
 
@@ -53,11 +61,13 @@ struct CC_EXPORT BeginFrameArgs {
   base::TimeTicks frame_time;
   base::TimeTicks deadline;
   base::TimeDelta interval;
+  BeginFrameArgsType type;
 
  private:
   BeginFrameArgs(base::TimeTicks frame_time,
                  base::TimeTicks deadline,
-                 base::TimeDelta interval);
+                 base::TimeDelta interval,
+                 BeginFrameArgsType type);
 };
 
 }  // namespace cc