cc/trees/thread_proxy.h - Issue 267783004: Refactoring the way begin frame sources inside scheduler work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/thread_proxy.h

Issue 267783004: Refactoring the way begin frame sources inside scheduler work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Lots of review comment fixes, plus addition of OnMissedBeginFrame. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/thread_proxy.h

diff --git a/cc/trees/thread_proxy.h b/cc/trees/thread_proxy.h

index ff7325c4291032cbd263309fa278ed7d3e1f060d..f6453781c05d3e94bd37a6c41c64f68eec191620 100644

--- a/cc/trees/thread_proxy.h

+++ b/cc/trees/thread_proxy.h

@@ -180,7 +180,6 @@ class CC_EXPORT ThreadProxy : public Proxy,

virtual void CommitVSyncParameters(base::TimeTicks timebase,

base::TimeDelta interval) OVERRIDE;

virtual void SetEstimatedParentDrawTime(base::TimeDelta draw_time) OVERRIDE;

- virtual void BeginFrame(const BeginFrameArgs& args) OVERRIDE;

virtual void SetMaxSwapsPendingOnImplThread(int max) OVERRIDE;

virtual void DidSwapBuffersOnImplThread() OVERRIDE;

virtual void DidSwapBuffersCompleteOnImplThread() OVERRIDE;

@@ -210,7 +209,7 @@ class CC_EXPORT ThreadProxy : public Proxy,

virtual void DidManageTiles() OVERRIDE;

// SchedulerClient implementation

- virtual void SetNeedsBeginFrame(bool enable) OVERRIDE;

+ virtual BeginFrameSource* ExternalBeginFrameSource() OVERRIDE;

virtual void WillBeginImplFrame(const BeginFrameArgs& args) OVERRIDE;

virtual void ScheduledActionSendBeginMainFrame() OVERRIDE;

virtual DrawResult ScheduledActionDrawAndSwapIfPossible() OVERRIDE;