Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3819)

Unified Diff: cc/test/ordered_simple_task_runner.cc

Issue 267783004: Refactoring the way begin frame sources inside scheduler work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Major rewrite based on Brian's comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/ordered_simple_task_runner.cc
diff --git a/cc/test/ordered_simple_task_runner.cc b/cc/test/ordered_simple_task_runner.cc
index 9f7f789954273d7a3274b9cdb022f1d2d7bfff03..e049484acd1d21f16fcfafce89fdb9d19547fd8c 100644
--- a/cc/test/ordered_simple_task_runner.cc
+++ b/cc/test/ordered_simple_task_runner.cc
@@ -127,6 +127,10 @@ bool OrderedSimpleTaskRunner::RunsTasksOnCurrentThread() const {
return true;
}
+bool OrderedSimpleTaskRunner::HasPendingTasks() {
+ return pending_tasks_.size() > 0;
+}
+
base::TimeTicks OrderedSimpleTaskRunner::NextTaskTime() {
if (pending_tasks_.size() <= 0) {
return TestNowSource::kAbsoluteMaxNow;
@@ -202,7 +206,7 @@ bool OrderedSimpleTaskRunner::RunTasksWhile(
// Conditions could modify the pending task length, so we need to recheck
// that there are tasks to run.
- if (!condition_success || pending_tasks_.size() == 0) {
+ if (!condition_success || !HasPendingTasks()) {
break;
}
@@ -219,7 +223,7 @@ bool OrderedSimpleTaskRunner::RunTasksWhile(
pending_tasks_.erase(task_to_run);
}
- return pending_tasks_.size() > 0;
+ return HasPendingTasks();
}
bool OrderedSimpleTaskRunner::RunPendingTasks() {

Powered by Google App Engine
This is Rietveld 408576698