Refactoring the way begin frame sources inside scheduler work.

cc/test/scheduler_test_common.h

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_TEST_SCHEDULER_TEST_COMMON_H_
 #define CC_TEST_SCHEDULER_TEST_COMMON_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/time/time.h"
 #include "cc/scheduler/delay_based_time_source.h"
 #include "cc/scheduler/scheduler.h"
 #include "cc/test/ordered_simple_task_runner.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
 
 class FakeTimeSourceClient : public TimeSourceClient {
  public:
   FakeTimeSourceClient() { Reset(); }
   void Reset() { tick_called_ = false; }
   bool TickCalled() const { return tick_called_; }
 
   // TimeSourceClient implementation.
   virtual void OnTimerTick() OVERRIDE;
 
  protected:
-  bool tick_called_;
+  bool tick_called_ = false;

[Sami, 2014/09/18 13:55:09]

I think this is a C++11-ism which we don't allow yet.

[mithro-old, 2014/09/19 02:45:39]

As Chrome style doesn't seem to used this, I've removed it.

Just FYI, this is actually perfectly valid C++98 if the type is "int compatible"
(IE bool, int, pointer, etc - but not double!). What changes in C++11 is that
this syntax is extended to support more than "int compatible" values through the
use of constexpr.

[Sami, 2014/09/19 13:44:22]

Interesting, I didn't know that.

[mithro-old, 2014/09/23 12:43:54]

It has the nice feature that if you forget to initialize the value in one of the
constructors, it still gets a value rather than it being randomly determined by
what the contents of the memory was before (and hence spend hours trying to
figure out why your test is non-deterministic but never fails when you enable
tracing :/).

 };
 
 class FakeDelayBasedTimeSource : public DelayBasedTimeSource {
  public:
   static scoped_refptr<FakeDelayBasedTimeSource> Create(
       base::TimeDelta interval, base::SingleThreadTaskRunner* task_runner) {
     return make_scoped_refptr(new FakeDelayBasedTimeSource(interval,
                                                            task_runner));
   }
 
@@ skipping 25 matching lines @@
                            OrderedSimpleTaskRunner* task_runner);
 
   // Overridden from DelayBasedTimeSource
   virtual ~TestDelayBasedTimeSource();
   virtual base::TimeTicks Now() const OVERRIDE;
   virtual std::string TypeString() const OVERRIDE;
 
   scoped_refptr<TestNowSource> now_src_;
 };
 
+struct FakeBeginFrameSource : public BeginFrameSource {
+  bool needs_begin_frames_ = false;

[Sami, 2014/09/18 13:55:09]

Ditto.

[mithro-old, 2014/09/19 02:45:39]

Done.

+  bool remaining_frames_ = false;
+
+  BeginFrameObserver* GetObserver() { return observer_; }
+
+  void TestSendBeginFrame(const BeginFrameArgs& args) {

[brianderson, 2014/09/18 21:54:19]

TestOnBeginFrame.

[mithro-old, 2014/09/19 02:45:39]

Done.

+    CallOnBeginFrame(args);
+  }
+
+  // BeginFrameSource
+  virtual bool NeedsBeginFrames() const OVERRIDE;
+  virtual void SetNeedsBeginFrames(bool needs_begin_frames) OVERRIDE;
+  virtual void DidFinishFrame(size_t remaining_frames) OVERRIDE;
+
+  virtual void AsValueInto(base::debug::TracedValue* dict) const OVERRIDE;
+
+  virtual ~FakeBeginFrameSource() {}
+};
+
+class TestBackToBackBeginFrameSource : public BackToBackBeginFrameSource {
+ public:
+  virtual ~TestBackToBackBeginFrameSource();
+
+  static scoped_ptr<TestBackToBackBeginFrameSource> Create(
+      scoped_refptr<TestNowSource> now_src,
+      base::SingleThreadTaskRunner* task_runner) {
+    return make_scoped_ptr(
+        new TestBackToBackBeginFrameSource(now_src, task_runner));
+  }
+
+ protected:
+  TestBackToBackBeginFrameSource(scoped_refptr<TestNowSource> now_src,
+                                 base::SingleThreadTaskRunner* task_runner);
+
+  virtual base::TimeTicks Now() OVERRIDE;
+
+  scoped_refptr<TestNowSource> now_src_;
+};
+
+class TestSyntheticBeginFrameSource : public SyntheticBeginFrameSource {
+ public:
+  virtual ~TestSyntheticBeginFrameSource();
+
+  static scoped_ptr<TestSyntheticBeginFrameSource> Create(
+      scoped_refptr<TestNowSource> now_src,
+      OrderedSimpleTaskRunner* task_runner,
+      base::TimeDelta initial_interval) {
+    base::TimeTicks initial_timebase = now_src->Now();
+    return make_scoped_ptr(new TestSyntheticBeginFrameSource(
+        TestDelayBasedTimeSource::Create(
+            now_src, initial_interval, task_runner),
+        initial_timebase,
+        initial_interval));
+  }
+
+ protected:
+  TestSyntheticBeginFrameSource(scoped_refptr<DelayBasedTimeSource> time_source,
+                                base::TimeTicks initial_timebase,
+                                base::TimeDelta initial_interval);
+};
+
 class TestScheduler : public Scheduler {
  public:
   static scoped_ptr<TestScheduler> Create(
       scoped_refptr<TestNowSource> now_src,
       SchedulerClient* client,
       const SchedulerSettings& scheduler_settings,
       int layer_tree_host_id) {
     // A bunch of tests require Now() to be > BeginFrameArgs::DefaultInterval()
     now_src->AdvanceNow(base::TimeDelta::FromMilliseconds(100));
 
     scoped_refptr<OrderedSimpleTaskRunner> test_task_runner =
         new OrderedSimpleTaskRunner(now_src, true);
-    return make_scoped_ptr(new TestScheduler(now_src,
-                                             client,
-                                             scheduler_settings,
-                                             layer_tree_host_id,
-                                             test_task_runner));
+    scoped_ptr<TestScheduler> scheduler =
+        make_scoped_ptr(new TestScheduler(now_src,
+                                          client,
+                                          scheduler_settings,
+                                          layer_tree_host_id,
+                                          test_task_runner));
+    scheduler->FinalizeSetup();
+    return scheduler.Pass();
   }
 
   // Extra test helper functionality
   bool IsBeginRetroFrameArgsEmpty() const {
     return begin_retro_frame_args_.empty();
   }
 
-  bool IsSyntheticBeginFrameSourceActive() const {
-    return synthetic_begin_frame_source_->IsActive();
-  }
-
+  BeginFrameSource& frame_source() { return *frame_source_; }
   OrderedSimpleTaskRunner& task_runner() { return *test_task_runner_; }
 
   virtual ~TestScheduler();
 
  protected:
   // Overridden from Scheduler.
   virtual base::TimeTicks Now() const OVERRIDE;
+  virtual BeginFrameSource* GetPrimaryBeginFrameSource() OVERRIDE;
+  virtual BeginFrameSource* GetBackgroundBeginFrameSource() OVERRIDE;
 
  private:
   TestScheduler(scoped_refptr<TestNowSource> now_src,
                 SchedulerClient* client,
                 const SchedulerSettings& scheduler_settings,
                 int layer_tree_host_id,
                 const scoped_refptr<OrderedSimpleTaskRunner>& test_task_runner);
 
   scoped_refptr<TestNowSource> now_src_;
   OrderedSimpleTaskRunner* test_task_runner_;
 };
 
 }  // namespace cc
 
 #endif  // CC_TEST_SCHEDULER_TEST_COMMON_H_