Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart

Issue 2677663003: Update plugin spec (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
diff --git a/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart b/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
index 8ed76312db0631bca600708ff7e8400942de6212..b7306d34bbcc1a3cdc1d7068677ca0e011517e5e 100644
--- a/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
+++ b/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart
@@ -30,6 +30,11 @@ abstract class IntegrationTestMixin {
*
* Parameters
*
+ * byteStorePath (String)
+ *
+ * The path to the directory containing the on-disk byte store that is to
+ * be used by any analysis drivers that are created.
+ *
* version (String)
*
* The version number of the plugin spec supported by the analysis server
@@ -53,10 +58,10 @@ abstract class IntegrationTestMixin {
* The version of the plugin. This value is only used when the server needs
* to identify the plugin, either to the user or for debugging purposes.
*
- * email (optional String)
+ * contactInfo (optional String)
*
- * An e-mail address that either the client or the user can use to contact
- * the maintainers of the plugin when there is a problem.
+ * Information that the user can use to use to contact the maintainers of
+ * the plugin when there is a problem.
*
* interestingFiles (List<String>)
*
@@ -65,8 +70,8 @@ abstract class IntegrationTestMixin {
* Otherwise, it will be used to identify the files for which the plugin
* should be notified of changes.
*/
- Future<PluginVersionCheckResult> sendPluginVersionCheck(String version) async {
- var params = new PluginVersionCheckParams(version).toJson();
+ Future<PluginVersionCheckResult> sendPluginVersionCheck(String byteStorePath, String version) async {
+ var params = new PluginVersionCheckParams(byteStorePath, version).toJson();
var result = await server.send("plugin.versionCheck", params);
ResponseDecoder decoder = new ResponseDecoder(null);
return new PluginVersionCheckResult.fromJson(decoder, 'result', result);

Powered by Google App Engine
This is Rietveld 408576698