Update plugin spec

Update plugin spec

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/17a447c89e301b45b012059e4005b10b59aba492

[Brian Wilkerson, 2017-02-03 23:52:14]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-02-03 23:52:15]

This replaces the 'email' field with a 'contactInfo' field and adds a mechanism
for server to tell plugins where to find the on-disk byte store.

[scheglov, 2017-02-04 02:01:16]

LGTM

https://codereview.chromium.org/2677663003/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2677663003/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:273: new MemoryCachingByteStore(new
FileByteStore(byteStorePath, G), 64 * M);
We might want to avoid using FileByteStore in plugins.
We want to read and write to the same cache.
But FileByteStore also scans the cache directory and evicts older entries.
It is better to have one isolate that does this, in Analysis Server itself.
Let's discuss it on Monday.

[Brian Wilkerson, 2017-02-04 18:06:56]

https://codereview.chromium.org/2677663003/diff/1/pkg/analyzer_plugin/lib/plu...
File pkg/analyzer_plugin/lib/plugin/plugin.dart (right):

https://codereview.chromium.org/2677663003/diff/1/pkg/analyzer_plugin/lib/plu...
pkg/analyzer_plugin/lib/plugin/plugin.dart:273: new MemoryCachingByteStore(new
FileByteStore(byteStorePath, G), 64 * M);
> But FileByteStore also scans the cache directory and evicts older entries.

Ah, I didn't realize it did that much. Could we pull the eviction into a
separate class (something like ByteStoreReaper) so that FileByteStore can be
re-used?

[Brian Wilkerson, 2017-02-07 16:02:57]

Issue resolved such that it is safe to use FileByteStore in plugins.

[Brian Wilkerson, 2017-02-07 16:03:18]

Description was changed from

==========
Update plugin spec
==========

to

==========
Update plugin spec

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/17a447c89e301b45b012059e4005b10b59aba492
==========

[Brian Wilkerson, 2017-02-07 16:03:19]

Committed patchset #1 (id:1) manually as
17a447c89e301b45b012059e4005b10b59aba492 (presubmit successful).