Fix receiver checks for v8::Function on a remote context.

test/cctest/test-access-checks.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdlib.h>
 
 #include "test/cctest/cctest.h"
 
 namespace {
 
@@ skipping 84 matching lines @@
 
 void IndexedEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info) {
   CHECK(g_expect_interceptor_call);
   v8::Isolate* isolate = info.GetIsolate();
   v8::Local<v8::Context> context = isolate->GetCurrentContext();
   v8::Local<v8::Array> names = v8::Array::New(isolate, 1);
   names->Set(context, 0, v8_str("7")).FromJust();
   info.GetReturnValue().Set(names);
 }
 
+void MethodGetter(v8::Local<v8::Name> property,
+                  const v8::PropertyCallbackInfo<v8::Value>& info) {
+  v8::Isolate* isolate = info.GetIsolate();
+  v8::Local<v8::Context> context = isolate->GetCurrentContext();
+
+  v8::Local<v8::External> data = info.Data().As<v8::External>();
+  v8::Local<v8::FunctionTemplate>& function_template =
+      *reinterpret_cast<v8::Local<v8::FunctionTemplate>*>(data->Value());
+
+  info.GetReturnValue().Set(
+      function_template->GetFunction(context).ToLocalChecked());
+}
+
+void MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
+  info.GetReturnValue().Set(8);
+}
+
 void NamedGetterThrowsException(
     v8::Local<v8::Name> property,
     const v8::PropertyCallbackInfo<v8::Value>& info) {
   info.GetIsolate()->ThrowException(v8_str("exception"));
 }
 
 void NamedSetterThrowsException(
     v8::Local<v8::Name> property, v8::Local<v8::Value> value,
     const v8::PropertyCallbackInfo<v8::Value>& info) {
   info.GetIsolate()->ThrowException(v8_str("exception"));
@@ skipping 166 matching lines @@
   v8::Local<v8::Context> context0 =
       v8::Context::New(isolate, nullptr, global_template);
   CheckCanRunScriptInContext(isolate, context0);
 
   // Create another context.
   v8::Local<v8::Context> context1 =
       v8::Context::New(isolate, nullptr, global_template);
   CheckCrossContextAccess(isolate, context1, context0->Global());
 }
 
+TEST(CallFunctionWithRemoteContextReceiver) {
+  v8::Isolate* isolate = CcTest::isolate();
+  v8::HandleScope scope(isolate);
+  v8::Local<v8::FunctionTemplate> global_template =
+      v8::FunctionTemplate::New(isolate);
+
+  v8::Local<v8::Signature> signature =
+      v8::Signature::New(isolate, global_template);
+  v8::Local<v8::FunctionTemplate> function_template = v8::FunctionTemplate::New(
+      isolate, MethodCallback, v8::External::New(isolate, &function_template),
+      signature);
+
+  global_template->InstanceTemplate()->SetAccessCheckCallbackAndHandler(
+      AccessCheck, v8::NamedPropertyHandlerConfiguration(
+                       MethodGetter, nullptr, nullptr, nullptr, nullptr,
+                       v8::External::New(isolate, &function_template)),
+      v8::IndexedPropertyHandlerConfiguration());
+
+  v8::Local<v8::Object> accessed_object =
+      v8::Context::NewRemoteContext(isolate,
+                                    global_template->InstanceTemplate())
+          .ToLocalChecked();
+  v8::Local<v8::Context> accessing_context =
+      v8::Context::New(isolate, nullptr, global_template->InstanceTemplate());
+
+  v8::HandleScope handle_scope(isolate);
+  accessing_context->Global()
+      ->Set(accessing_context, v8_str("other"), accessed_object)
+      .FromJust();
+  v8::Context::Scope context_scope(accessing_context);
+
+  {
+    v8::TryCatch try_catch(isolate);
+    ExpectInt32("this.other.method()", 8);
+    CHECK(!try_catch.HasCaught());
+  }
+}
+
 TEST(AccessCheckWithExceptionThrowingInterceptor) {
   v8::Isolate* isolate = CcTest::isolate();
   isolate->SetFailedAccessCheckCallbackFunction([](v8::Local<v8::Object> target,
                                                    v8::AccessType type,
                                                    v8::Local<v8::Value> data) {
     CHECK(false);  // This should never be called.
   });
 
   v8::HandleScope scope(isolate);
   v8::Local<v8::ObjectTemplate> global_template =
@@ skipping 94 matching lines @@
                                               IndexedEnumerator));
   tmpl->SetNativeDataProperty(
       v8_str("all_can_read"), Return42, nullptr, v8::Local<v8::Value>(),
       v8::None, v8::Local<v8::AccessorSignature>(), v8::ALL_CAN_READ);
 
   v8::Local<v8::Object> obj = tmpl->NewRemoteInstance().ToLocalChecked();
 
   v8::Local<v8::Context> context = v8::Context::New(isolate);
   CheckCrossContextAccess(isolate, context, obj);
 }