chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h - Issue 2677563005: Chromad: Use DM server reply to determine enrollment type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h

Issue 2677563005: Chromad: Use DM server reply to determine enrollment type (Closed)

Patch Set: comments+create ActiveDirectoryJoinDelegate Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.cc ('k') | chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc » ('j') | chrome/browser/chromeos/login/screens/host_pairing_screen.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h

diff --git a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h

index af03c527914195183302ce33f612a0f8aa993e7c..e6d345624b9d79c60abdbc67fb2a83a7f984dae8 100644

--- a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h

+++ b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h

@@ -27,6 +27,7 @@ class EnterpriseEnrollmentHelperImpl : public EnterpriseEnrollmentHelper {

public:

EnterpriseEnrollmentHelperImpl(

EnrollmentStatusConsumer* status_consumer,

+ ActiveDirectoryJoinDelegate* join_delegate,

achuithb 2017/02/13 13:39:02 ad_join_delegate here and everywhere else?

Roman Sorokin (ftl) 2017/02/14 12:47:10 Done.

const policy::EnrollmentConfig& enrollment_config,

const std::string& enrolling_user_domain);

~EnterpriseEnrollmentHelperImpl() override;

@@ -88,6 +89,7 @@ class EnterpriseEnrollmentHelperImpl : public EnterpriseEnrollmentHelper {

bool oauth_data_cleared_ = false;

std::string oauth_token_;

bool success_ = false;

+ ActiveDirectoryJoinDelegate* join_delegate_;

achuithb 2017/02/13 13:39:02 ad_join_delegate_? Also, initialize to nullptr fo

Roman Sorokin (ftl) 2017/02/14 12:47:10 Done.

std::unique_ptr<policy::PolicyOAuth2TokenFetcher> oauth_fetcher_;