Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 26775010: fix build after clang roll (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
CC:
chromium-reviews, tzik
Visibility:
Public.

Description

fix build after clang roll ../../chrome/browser/sync_file_system/drive_backend/sync_engine.cc:33:21:error: field 'weak_ptr_factory_' is uninitialized when used here [-Werror,-Wuninitialized] task_manager_(weak_ptr_factory_.GetWeakPtr()), ^ This is wrong as WeakPtrFactory should be last, but let's fix the build for now (and the code as-is is broken too, so it's not making things worse). This was broken by https://codereview.chromium.org/26594002/ BUG=303818, 290204 TBR=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 2 months ago (2013-10-12 06:36:59 UTC) #1
Nico
Committed patchset #1 manually as r228322.
7 years, 2 months ago (2013-10-12 06:37:07 UTC) #2
dmichael (off chromium)
That's a nice new warning. This is not the only one I messed up tearing ...
7 years, 2 months ago (2013-10-12 13:24:36 UTC) #3
kinuko
7 years, 2 months ago (2013-10-15 03:13:35 UTC) #4
Message was sent while issue was closed.
(cc-ing tzik)

Powered by Google App Engine
This is Rietveld 408576698