Fix an assertion about canonical types in the precompiler.

Fix an assertion about canonical types in the precompiler.

Recursive types can be equivalent, but have loops of different lengths, therefore not always canonicalized.

When rehashing, don't forget the last element.

Adjust integer type in hash code computation. It should not make
a difference, but seems consistent to use the same size of both
sides.


BUG=
R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/dbb1a1caa282bfb6bcbee90ea50ac4f8f3441644

[Florian Schneider, 2017-02-02 23:17:17]

Description was changed from

==========
Fix an assertion about canonical types in the precompiler.

When rehashing, don't forget the last element.

Adjust integer type in hash code computation. It should not make
a difference, but seems consistent to use the same size of both
sides.


BUG=
==========

to

==========
Fix an assertion about canonical types in the precompiler.

Recursive types can be equivalent, but have loops of different lengths,
therefore not always canonicalized.

When rehashing, don't forget the last element.

Adjust integer type in hash code computation. It should not make
a difference, but seems consistent to use the same size of both
sides.


BUG=
==========

[Florian Schneider, 2017-02-02 23:18:15]

fschneider@google.com changed reviewers:
+ regis@google.com, rmacnak@google.com

[Florian Schneider, 2017-02-02 23:18:15]

Small code review

[regis, 2017-02-02 23:26:08]

lgtm with one addition.

https://codereview.chromium.org/2677473003/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2677473003/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:2720: ASSERT(!present);
ASSERT(!present || typearg.IsRecursive());

A type vector is considered recursive if any one of its type arguments is
recursive.

[Florian Schneider, 2017-02-02 23:36:42]

https://codereview.chromium.org/2677473003/diff/1/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/2677473003/diff/1/runtime/vm/precompiler.cc#n...
runtime/vm/precompiler.cc:2720: ASSERT(!present);
On 2017/02/02 23:26:08, regis wrote:
> ASSERT(!present || typearg.IsRecursive());
> 
> A type vector is considered recursive if any one of its type arguments is
> recursive.

Done.

[Florian Schneider, 2017-02-03 00:13:32]

Description was changed from

==========
Fix an assertion about canonical types in the precompiler.

Recursive types can be equivalent, but have loops of different lengths,
therefore not always canonicalized.

When rehashing, don't forget the last element.

Adjust integer type in hash code computation. It should not make
a difference, but seems consistent to use the same size of both
sides.


BUG=
==========

to

==========
Fix an assertion about canonical types in the precompiler.

Recursive types can be equivalent, but have loops of different lengths,
therefore not always canonicalized.

When rehashing, don't forget the last element.

Adjust integer type in hash code computation. It should not make
a difference, but seems consistent to use the same size of both
sides.


BUG=
R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dbb1a1caa282bfb6bcbee90ea50ac4f8f3441644
==========

[Florian Schneider, 2017-02-03 00:13:33]

Committed patchset #2 (id:20001) manually as
dbb1a1caa282bfb6bcbee90ea50ac4f8f3441644 (presubmit successful).