Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7766)

Unified Diff: ash/wm/maximize_mode/maximize_mode_controller.h

Issue 267743010: Suppressed screen rotation notifications triggeres by the accelerometer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed maximize_mode_controller to use it's own SetDisplayRotation method. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/maximize_mode/maximize_mode_controller.h
diff --git a/ash/wm/maximize_mode/maximize_mode_controller.h b/ash/wm/maximize_mode/maximize_mode_controller.h
index 9810d4d5bfc93019de796aec98baeb65790b1d66..8ff8ca141bba797edf8e1741f67f93a15bf71043 100644
--- a/ash/wm/maximize_mode/maximize_mode_controller.h
+++ b/ash/wm/maximize_mode/maximize_mode_controller.h
@@ -7,6 +7,7 @@
#include "ash/accelerometer/accelerometer_observer.h"
#include "ash/ash_export.h"
+#include "ash/display/display_manager.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
@@ -47,6 +48,11 @@ class ASH_EXPORT MaximizeModeController : public AccelerometerObserver {
virtual void OnAccelerometerUpdated(const gfx::Vector3dF& base,
const gfx::Vector3dF& lid) OVERRIDE;
+ // Only show display notifications when true.
+ bool show_display_notifications() const {
+ return show_display_notifications_;
+ }
+
private:
// Detect hinge rotation from |base| and |lid| accelerometers and
// automatically start / stop maximize mode.
@@ -57,6 +63,11 @@ class ASH_EXPORT MaximizeModeController : public AccelerometerObserver {
// screen.
void HandleScreenRotation(const gfx::Vector3dF& lid);
+ // Sets the display rotation and suppresses display notifications.
+ void SetDisplayRotation(DisplayManager* display_manager,
+ int64 display_id,
+ gfx::Display::Rotation rotation);
+
// An event targeter controller which traps mouse and keyboard events while
// maximize mode is engaged.
scoped_ptr<MaximizeModeEventBlocker> event_blocker_;
@@ -70,6 +81,9 @@ class ASH_EXPORT MaximizeModeController : public AccelerometerObserver {
// Whether we have ever seen accelerometer data.
bool have_seen_accelerometer_data_;
+ // When false MessageCenter display notifications will be suppressed.
+ bool show_display_notifications_;
flackr 2014/05/14 01:48:33 nit: this name describes the side effects of this
bruthig 2014/05/14 18:48:49 Done.
+
DISALLOW_COPY_AND_ASSIGN(MaximizeModeController);
};

Powered by Google App Engine
This is Rietveld 408576698