Suppressed screen rotation notifications triggeres by the accelerometer

ash/system/chromeos/tray_display.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/chromeos/tray_display.h"
 
 #include "ash/display/display_controller.h"
 #include "ash/display/display_manager.h"
 #include "ash/shell.h"
 #include "ash/system/system_notifier.h"
 #include "ash/system/tray/actionable_view.h"
 #include "ash/system/tray/fixed_sized_image_view.h"
 #include "ash/system/tray/system_tray.h"
 #include "ash/system/tray/system_tray_delegate.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ash/system/tray/tray_notification_view.h"
+#include "ash/wm/maximize_mode/maximize_mode_controller.h"
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ash_resources.h"
 #include "grit/ash_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/notification.h"
 #include "ui/message_center/notification_delegate.h"
@@ skipping 354 matching lines @@
       message,
       additional_message,
       bundle.GetImageNamed(IDR_AURA_NOTIFICATION_DISPLAY),
       base::string16(),  // display_source
       message_center::NotifierId(
           message_center::NotifierId::SYSTEM_COMPONENT,
           system_notifier::kNotifierDisplay),
       message_center::RichNotificationData(),
       new message_center::HandleNotificationClickedDelegate(
           base::Bind(&OpenSettings))));
-  message_center::MessageCenter::Get()->AddNotification(notification.Pass());
+
+  message_center::MessageCenter* message_center =
+      message_center::MessageCenter::Get();
+  MaximizeModeController* maximize_mode_controller =
+      Shell::GetInstance()->maximize_mode_controller();
+  // Display notifications caused from physically rotating the device
+  // would be annoying and not useful to the user.

[flackr, 2014/05/14 20:12:41]

Probably simply state that we don't display notifications for accelerometer
triggered screen rotations, can reference the bug for detailed rationale.

[bruthig, 2014/05/14 21:07:35]

Done.

+  if (maximize_mode_controller &&

[flackr, 2014/05/14 20:12:41]

Are there cases where this is called and MaximizeModeController hasn't been
instantiated yet? In general if something shouldn't happen (like
MaximizeModeController is always instantiated) we prefer to have it crash rather
than fail silently.

[bruthig, 2014/05/14 21:07:35]

Done.

+      !maximize_mode_controller->in_set_screen_rotation()) {
+    message_center->AddNotification(notification.Pass());
+  }

[flackr, 2014/05/14 20:12:41]

else dismiss an active notification if it exists?

[bruthig, 2014/05/14 21:07:35]

Previous notifications are already dismissed above at the start of this method.

 }
 
 views::View* TrayDisplay::CreateDefaultView(user::LoginStatus status) {
   DCHECK(default_ == NULL);
   default_ = new DisplayView();
   return default_;
 }
 
 void TrayDisplay::DestroyDefaultView() {
   default_ = NULL;
@@ skipping 27 matching lines @@
 bool TrayDisplay::GetAccessibleStateForTesting(ui::AXViewState* state) {
   views::View* view = default_;
   if (view) {
     view->GetAccessibleState(state);
     return true;
   }
   return false;
 }
 
 }  // namespace ash