Suppressed screen rotation notifications triggeres by the accelerometer

ash/wm/maximize_mode/maximize_mode_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/maximize_mode/maximize_mode_controller.h"
 
 #include "ash/accelerators/accelerator_controller.h"
 #include "ash/accelerators/accelerator_table.h"
 #include "ash/accelerometer/accelerometer_controller.h"
 #include "ash/ash_switches.h"
@@ skipping 114 matching lines @@
         ash::TAKE_SCREENSHOT, ui::Accelerator());
   }
 }
 
 #endif  // OS_CHROMEOS
 
 }  // namespace
 
 MaximizeModeController::MaximizeModeController()
     : rotation_locked_(false),
-      have_seen_accelerometer_data_(false) {
+      have_seen_accelerometer_data_(false),
+      show_display_notifications_(true) {
   Shell::GetInstance()->accelerometer_controller()->AddObserver(this);
 }
 
 MaximizeModeController::~MaximizeModeController() {
   Shell::GetInstance()->accelerometer_controller()->RemoveObserver(this);
 }
 
 bool MaximizeModeController::CanEnterMaximizeMode() {
   // If we have ever seen accelerometer data, then HandleHingeRotation may
   // trigger maximize mode at some point in the future.
@@ skipping 82 matching lines @@
   // If maximize mode is not engaged, ensure the screen is not rotated and
   // do not rotate to match the current device orientation.
   if (!maximize_mode_engaged) {
     if (current_rotation != gfx::Display::ROTATE_0) {
       // TODO(flackr): Currently this will prevent setting a manual rotation on
       // the screen of a device with an accelerometer, this should only set it
       // back to ROTATE_0 if it was last set by the accelerometer.
       // Also, SetDisplayRotation will save the setting to the local store,
       // this should be stored in a way that we can distinguish what the
       // rotation was set by.
-      display_manager->SetDisplayRotation(gfx::Display::InternalDisplayId(),
-                                          gfx::Display::ROTATE_0);
+      SetDisplayRotation(display_manager,
+                         gfx::Display::InternalDisplayId(),
+                         gfx::Display::ROTATE_0);
     }
     rotation_locked_ = false;
     return;
   }
 
   if (rotation_locked_)
     return;
 
   // After determining maximize mode state, determine if the screen should
   // be rotated.
@@ skipping 37 matching lines @@
     new_rotation = gfx::Display::ROTATE_0;
   else if (angle < 180.0f)
     new_rotation = gfx::Display::ROTATE_270;
   else if (angle < 270.0f)
     new_rotation = gfx::Display::ROTATE_180;
 
   // When exiting maximize mode return rotation to 0. When entering, rotate to
   // match screen orientation.
   if (new_rotation == gfx::Display::ROTATE_0 ||
       maximize_mode_engaged) {
-    display_manager->SetDisplayRotation(gfx::Display::InternalDisplayId(),
-                                        new_rotation);
+    SetDisplayRotation(display_manager,
+                       gfx::Display::InternalDisplayId(),
+                       new_rotation);
   }
 }
 
+void MaximizeModeController::SetDisplayRotation(
+    DisplayManager* display_manager,
+    int64 display_id,

[jonross, 2014/05/14 01:00:39]

We only ever operate on the internal display, this parameter can be removed.

[bruthig, 2014/05/14 18:48:49]

Done.

+    gfx::Display::Rotation rotation) {
+  // Suppress message centre notifications for screen rotations caused
+  // by accelerometer events because it should be obvious why the orientation
+  // changed.
+  show_display_notifications_ = false;

[flackr, 2014/05/14 01:48:33]

nit: Use base::AutoReset.

[bruthig, 2014/05/14 18:48:49]

Done.

+  display_manager->SetDisplayRotation(display_id, rotation);
+  show_display_notifications_ = true;
+}
+
 }  // namespace ash