Suppressed screen rotation notifications triggeres by the accelerometer

ash/wm/maximize_mode/maximize_mode_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_MAXIMIZE_MODE_MAXIMIZE_MODE_CONTROLLER_H_
 #define ASH_WM_MAXIMIZE_MODE_MAXIMIZE_MODE_CONTROLLER_H_
 
 #include "ash/accelerometer/accelerometer_observer.h"
 #include "ash/ash_export.h"
+#include "ash/display/display_manager.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
+#include "ui/message_center/message_center.h"
 
 namespace ash {
 
 class MaximizeModeEventBlocker;
 
 // MaximizeModeController listens to accelerometer events and automatically
 // enters and exits maximize mode when the lid is opened beyond the triggering
 // angle and rotates the display to match the device when in maximize mode.
-class ASH_EXPORT MaximizeModeController : public AccelerometerObserver {
+class ASH_EXPORT MaximizeModeController
+    : public message_center::NotificationBlocker,
+      public AccelerometerObserver {
  public:
   MaximizeModeController();
   virtual ~MaximizeModeController();
 
   // True if |rotation_lock_| has been set, and OnAccelerometerUpdated will not
   // change the display rotation.
   bool rotation_locked() {
     return rotation_locked_;
   }
 
   // If |rotation_locked| future calls to OnAccelerometerUpdated will not
   // change the display rotation.
   void set_rotation_locked(bool rotation_locked) {
     rotation_locked_ = rotation_locked;
   }
 
   // AccelerometerObserver:
   virtual void OnAccelerometerUpdated(const gfx::Vector3dF& base,
                                       const gfx::Vector3dF& lid) OVERRIDE;
 
+  // message_center::NotificationBlocker:
+  virtual bool ShouldShowNotificationAsPopup(
+      const message_center::NotifierId& notifier_id) const OVERRIDE;
+  virtual bool ShouldShowNotification(
+      const message_center::NotifierId& notifier_id) const OVERRIDE;

[jonross, 2014/05/09 14:57:33]

Nit: empty line after a function and a new scope delimiter like "private:"

[bruthig, 2014/05/14 00:36:16]

Done.

  private:
   // Detect hinge rotation from |base| and |lid| accelerometers and
   // automatically start / stop maximize mode.
   void HandleHingeRotation(const gfx::Vector3dF& base,
                            const gfx::Vector3dF& lid);
 
   // Detect screen rotation from |lid| accelerometer and automatically rotate
   // screen.
   void HandleScreenRotation(const gfx::Vector3dF& lid);
 
+  // Sets the display rotation and suppresses display notifications.
+  void SetDisplayRotation(DisplayManager* display_manager,

[jonross, 2014/05/09 14:57:33]

Please forward declare DisplayManager

[bruthig, 2014/05/14 00:36:16]

gfx::Display::Rotation also comes from display_manager.h

+                          int64 display_id,
+                          gfx::Display::Rotation rotation);
+
+  // Set whether rotation notifications should be shown.
+  void set_show_notifications(bool should_show);

[flackr, 2014/05/08 21:56:15]

non-trivial methods should use TitleCase. I.e. anything that's not just a setter
or getter.

[bruthig, 2014/05/14 00:36:16]

Done.

+
   // Enables MaximizeModeWindowManager, and determines the current state of
   // rotation lock.
   void EnterMaximizeMode();
 
   // Removes MaximizeModeWindowManager and resets the display rotation if there
   // is no rotation lock.
   void LeaveMaximizeMode();
 
   // An event handler which traps mouse and keyboard events while maximize
   // mode is engaged.
   scoped_ptr<MaximizeModeEventBlocker> event_blocker_;
 
   // When true calls to OnAccelerometerUpdated will not rotate the display.
   bool rotation_locked_;
 
+  // When true will display notifications.  Use set_show_notifications to
+  // change the value.
+  bool show_notifications_;
+
   DISALLOW_COPY_AND_ASSIGN(MaximizeModeController);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_MAXIMIZE_MODE_MAXIMIZE_MODE_CONTROLLER_H_