Issue 267743008: Mojo: Use ./<(RULE_INPUT_DIRNAME) in mojom_bindings_generator.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267743008: Mojo: Use ./<(RULE_INPUT_DIRNAME) in mojom_bindings_generator.gypi. (Closed)

Created:
6 years, 7 months ago by Sam McNally

Modified:
6 years, 7 months ago

Reviewers:
darin (slow to review), viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Mojo: Use ./<(RULE_INPUT_DIRNAME) in mojom_bindings_generator.gypi. RULE_INPUT_DIRNAME is empty for input files in the same directory as the gyp file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268149

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mojo/public/tools/bindings/mojom_bindings_generator.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/267743008/1

6 years, 7 months ago (2014-05-05 05:59:13 UTC) #4

Message was sent while issue was closed.

Change committed as 268149

Expand Messages | Collapse Messages