sync/internal_api/sync_encryption_handler_impl.cc - Issue 267743003: Refactor password sync integration tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_encryption_handler_impl.cc

Issue 267743003: Refactor password sync integration tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: More review fixes Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/sync_encryption_handler_impl.cc

diff --git a/sync/internal_api/sync_encryption_handler_impl.cc b/sync/internal_api/sync_encryption_handler_impl.cc

index 34bf0335c8f6b31dbb010f1faf0472643442f665..d3dd33f773b78b5ca7725ea27b44297e02449fee 100644

--- a/sync/internal_api/sync_encryption_handler_impl.cc

+++ b/sync/internal_api/sync_encryption_handler_impl.cc

@@ -344,7 +344,6 @@ void SyncEncryptionHandlerImpl::SetEncryptionPassphrase(

// encryption is to set a custom passphrase.

if (IsNigoriMigratedToKeystore(node.GetNigoriSpecifics())) {

if (!is_explicit) {

- DCHECK(cryptographer->is_ready());

// The user is setting a new implicit passphrase. At this point we don't

// care, so drop it on the floor. This is safe because if we have a

// migrated nigori node, then we don't need to create an initial