Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2677423002: Small fix to perf.dart. (Closed)

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Small fix to perf.dart. This also makes perf_test.dart do something useful. It now executes perf.dart on a small file from pkg/front_end. This may help to detect early when the peformance bots will see a failure. I've only tested this in linux, but given that's the OS of the perf bots, I'm ok skipping this in other OSs. R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/25e94e2e0b7544a6eef532ce2ea6248280794925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M pkg/front_end/lib/kernel_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/tool/perf.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/tool/perf_test.dart View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-07 01:06:02 UTC) #3
Paul Berry
lgtm
3 years, 10 months ago (2017-02-07 12:58:20 UTC) #4
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-07 23:08:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
25e94e2e0b7544a6eef532ce2ea6248280794925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698