Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: src/parsing/parser.cc

Issue 2677373002: [parser] Cleanup: remove unused parameters to DeclareFunction (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/parsing/parser.h" 5 #include "src/parsing/parser.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/ast/ast-expression-rewriter.h" 10 #include "src/ast/ast-expression-rewriter.h"
(...skipping 1463 matching lines...) Expand 10 before | Expand all | Expand 10 after
1474 Block* block, const DeclarationDescriptor* declaration_descriptor, 1474 Block* block, const DeclarationDescriptor* declaration_descriptor,
1475 const DeclarationParsingResult::Declaration* declaration, 1475 const DeclarationParsingResult::Declaration* declaration,
1476 ZoneList<const AstRawString*>* names, bool* ok) { 1476 ZoneList<const AstRawString*>* names, bool* ok) {
1477 DCHECK_NOT_NULL(block); 1477 DCHECK_NOT_NULL(block);
1478 PatternRewriter::DeclareAndInitializeVariables( 1478 PatternRewriter::DeclareAndInitializeVariables(
1479 this, block, declaration_descriptor, declaration, names, ok); 1479 this, block, declaration_descriptor, declaration, names, ok);
1480 } 1480 }
1481 1481
1482 Statement* Parser::DeclareFunction(const AstRawString* variable_name, 1482 Statement* Parser::DeclareFunction(const AstRawString* variable_name,
1483 FunctionLiteral* function, VariableMode mode, 1483 FunctionLiteral* function, VariableMode mode,
1484 int pos, bool is_generator, bool is_async, 1484 int pos, bool is_sloppy_block_function,
1485 bool is_sloppy_block_function,
1486 ZoneList<const AstRawString*>* names, 1485 ZoneList<const AstRawString*>* names,
1487 bool* ok) { 1486 bool* ok) {
1488 VariableProxy* proxy = 1487 VariableProxy* proxy =
1489 factory()->NewVariableProxy(variable_name, NORMAL_VARIABLE); 1488 factory()->NewVariableProxy(variable_name, NORMAL_VARIABLE);
1490 1489
1491 DeclarationScope* target_scope = GetDeclarationScope(); 1490 DeclarationScope* target_scope = GetDeclarationScope();
1492 MarkTopLevelVariableAsAssigned(target_scope, proxy); 1491 MarkTopLevelVariableAsAssigned(target_scope, proxy);
1493 1492
1494 Declaration* declaration = 1493 Declaration* declaration =
1495 factory()->NewFunctionDeclaration(proxy, function, scope(), pos); 1494 factory()->NewFunctionDeclaration(proxy, function, scope(), pos);
(...skipping 3531 matching lines...) Expand 10 before | Expand all | Expand 10 after
5027 5026
5028 return final_loop; 5027 return final_loop;
5029 } 5028 }
5030 5029
5031 #undef CHECK_OK 5030 #undef CHECK_OK
5032 #undef CHECK_OK_VOID 5031 #undef CHECK_OK_VOID
5033 #undef CHECK_FAILED 5032 #undef CHECK_FAILED
5034 5033
5035 } // namespace internal 5034 } // namespace internal
5036 } // namespace v8 5035 } // namespace v8
OLDNEW
« no previous file with comments | « src/parsing/parser.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698