third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp - Issue 2677233002: Expose RTCPeerConnection.icegatheringstatechange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2677233002: Expose RTCPeerConnection.icegatheringstatechange. (Closed)

Patch Set: fix number of passing tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

index 8fd23dbfde05e35696379d469a3dd8f9f52d2975..d7b7f965bac5e4440974c82bdab507146b3c5fde 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

@@ -1395,7 +1395,12 @@ void RTCPeerConnection::changeSignalingState(SignalingState signalingState) {

void RTCPeerConnection::changeIceGatheringState(

ICEGatheringState iceGatheringState) {

- m_iceGatheringState = iceGatheringState;

+ if (m_iceConnectionState != ICEConnectionStateClosed &&

+ m_iceGatheringState != iceGatheringState) {

+ m_iceGatheringState = iceGatheringState;

+ scheduleDispatchEvent(

+ Event::create(EventTypeNames::icegatheringstatechange));

+ }

}

bool RTCPeerConnection::setIceConnectionState(

@@ -1427,7 +1432,6 @@ void RTCPeerConnection::closeInternal() {

m_closed = true;

changeIceConnectionState(ICEConnectionStateClosed);

- changeIceGatheringState(ICEGatheringStateComplete);

changeSignalingState(SignalingStateClosed);

Document* document = toDocument(getExecutionContext());

HostsUsingFeatures::countAnyWorld(