Add GN targets for third_party/libjpeg_turbo

Add GN targets for third_party/libjpeg_turbo

R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268421

[ckocagil, 2014-05-03 01:37:32]

PTAL. This currently doesn't compile .asm files on Linux (maybe because of the
file extension?).

Also, the original .gyp has yasm build rules. Should I convert them too? If so,
where should the rule be placed, here or somewhere in //build/?

[brettw, 2014-05-03 04:38:33]

lgtm

https://codereview.chromium.org/267723015/diff/1/build/config/BUILD.gn
File build/config/BUILD.gn (left):

https://codereview.chromium.org/267723015/diff/1/build/config/BUILD.gn#oldcode27
build/config/BUILD.gn:27: "USE_LIBJPEG_TURBO=1",
Yay!

https://codereview.chromium.org/267723015/diff/1/third_party/BUILD.gn
File third_party/BUILD.gn (right):

https://codereview.chromium.org/267723015/diff/1/third_party/BUILD.gn#newcode26
third_party/BUILD.gn:26: group("jpeg") {
Can you put an comment here about this meta-target? Also, I think it would be
good to put a comment above the two different jpeg librarys targets about using
//third_party:jpeg for switching based on the build flag.

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
File tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn (right):

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:6: if (cpu_arch == "ia32")
{
ia32 -> x86

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:155: # [
'target_arch=="arm"', {
This should be pretty easy to finish now:
at the top:
if (cpu_arch == "arm") {
  import("//build/config/arm.gni")
}

if (cpu_arch == "arm") {
 ...
}

arm_neon -> arm_use_neon
arm_neon_optional -> arm_optionally_use_neon

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:168: # }],
Can you put a TODO here about Windows & Mac?

[ckocagil, 2014-05-03 06:43:46]

https://codereview.chromium.org/267723015/diff/1/third_party/BUILD.gn
File third_party/BUILD.gn (right):

https://codereview.chromium.org/267723015/diff/1/third_party/BUILD.gn#newcode26
third_party/BUILD.gn:26: group("jpeg") {
On 2014/05/03 04:38:33, brettw wrote:
> Can you put an comment here about this meta-target? Also, I think it would be
> good to put a comment above the two different jpeg librarys targets about
using
> //third_party:jpeg for switching based on the build flag.

Done!

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
File tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn (right):

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:6: if (cpu_arch == "ia32")
{
On 2014/05/03 04:38:33, brettw wrote:
> ia32 -> x86

Done.

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:155: # [
'target_arch=="arm"', {
On 2014/05/03 04:38:33, brettw wrote:
> This should be pretty easy to finish now:
> at the top:
> if (cpu_arch == "arm") {
>   import("//build/config/arm.gni")
> }
> 
> if (cpu_arch == "arm") {
>  ...
> }
> 
> arm_neon -> arm_use_neon
> arm_neon_optional -> arm_optionally_use_neon

Done.

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:168: # }],
On 2014/05/03 04:38:33, brettw wrote:
> Can you put a TODO here about Windows & Mac?

About what exactly?

[brettw, 2014-05-05 18:09:04]

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
File tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn (right):

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:168: # }],
It looks like there's a whole bunch of stuff in the GUYP file with yasm and such
that isn't covered here. We should have a TODO(GYP) for anything not added yet.

[ckocagil, 2014-05-05 23:29:41]

+msw for ui/gfx/BUILD.gn

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
File tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn (right):

https://codereview.chromium.org/267723015/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn:168: # }],
On 2014/05/05 18:09:04, brettw wrote:
> It looks like there's a whole bunch of stuff in the GUYP file with yasm and
such
> that isn't covered here. We should have a TODO(GYP) for anything not added
yet.

Done.

[msw, 2014-05-05 23:39:34]

ui/gfx/BUILD.gn lgtm

[ckocagil, 2014-05-06 00:00:37]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-05-06 00:01:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/267723015/60001

[commit-bot: I haz the power, 2014-05-06 04:25:31]

Change committed as 268421