Issue 267723014: Make the Get Alarm Callback Parameter Optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 267723014: Make the Get Alarm Callback Parameter Optional (Closed)

Created:
6 years, 7 months ago by robliao

Modified:
6 years, 7 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, rgustafson, skare_

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make the Get Alarm Callback Parameter Optional In debug builds, the callback parameters are validated. Since this value is not sent on an alarm that doesn't exist, the validation fails. The fix here is to make the parameter optional. BUG=369636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267974

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/common/extensions/api/alarms.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/267723014/1

6 years, 7 months ago (2014-05-02 21:33:39 UTC) #4

Message was sent while issue was closed.

Change committed as 267974

Expand Messages | Collapse Messages