Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

Issue 267723012: Use FakeServer-based invalidations for Sync tests (try #2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/rand_util.h" 5 #include "base/rand_util.h"
6 #include "chrome/browser/profiles/profile.h" 6 #include "chrome/browser/profiles/profile.h"
7 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 7 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
8 #include "chrome/browser/sync/test/integration/passwords_helper.h" 8 #include "chrome/browser/sync/test/integration/passwords_helper.h"
9 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 9 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
10 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h" 10 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
(...skipping 1598 matching lines...) Expand 10 before | Expand all | Expand 10 after
1609 GURL url1 = GURL(IndexedURL(i+5)); 1609 GURL url1 = GURL(IndexedURL(i+5));
1610 ASSERT_TRUE(AddURL(1, folder1, i, title1, url1) != NULL); 1610 ASSERT_TRUE(AddURL(1, folder1, i, title1, url1) != NULL);
1611 } 1611 }
1612 1612
1613 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 1613 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
1614 ASSERT_TRUE(AwaitQuiescence()); 1614 ASSERT_TRUE(AwaitQuiescence());
1615 ASSERT_TRUE(AllModelsMatch()); 1615 ASSERT_TRUE(AllModelsMatch());
1616 ASSERT_FALSE(ContainsDuplicateBookmarks(0)); 1616 ASSERT_FALSE(ContainsDuplicateBookmarks(0));
1617 } 1617 }
1618 1618
1619 IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, MC_DeleteBookmark) { 1619 // This test fails when run with FakeServer and FakeServerInvalidationService.
1620 IN_PROC_BROWSER_TEST_F(LegacyTwoClientBookmarksSyncTest, MC_DeleteBookmark) {
1620 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 1621 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
1621 ASSERT_TRUE(GetClient(1)->DisableSyncForDatatype(syncer::BOOKMARKS)); 1622 ASSERT_TRUE(GetClient(1)->DisableSyncForDatatype(syncer::BOOKMARKS));
1622 1623
1623 const GURL bar_url("http://example.com/bar"); 1624 const GURL bar_url("http://example.com/bar");
1624 const GURL other_url("http://example.com/other"); 1625 const GURL other_url("http://example.com/other");
1625 1626
1626 ASSERT_TRUE(AddURL(0, GetBookmarkBarNode(0), 0, L"bar", bar_url) != NULL); 1627 ASSERT_TRUE(AddURL(0, GetBookmarkBarNode(0), 0, L"bar", bar_url) != NULL);
1627 ASSERT_TRUE(AddURL(0, GetOtherNode(0), 0, L"other", other_url) != NULL); 1628 ASSERT_TRUE(AddURL(0, GetOtherNode(0), 0, L"other", other_url) != NULL);
1628 1629
1629 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0)))); 1630 ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
2022 2023
2023 // Remove all 2024 // Remove all
2024 RemoveAll(0); 2025 RemoveAll(0);
2025 2026
2026 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 2027 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
2027 // Verify other node has no children now. 2028 // Verify other node has no children now.
2028 EXPECT_EQ(0, GetOtherNode(0)->child_count()); 2029 EXPECT_EQ(0, GetOtherNode(0)->child_count());
2029 EXPECT_EQ(0, GetBookmarkBarNode(0)->child_count()); 2030 EXPECT_EQ(0, GetBookmarkBarNode(0)->child_count());
2030 ASSERT_TRUE(AllModelsMatch()); 2031 ASSERT_TRUE(AllModelsMatch());
2031 } 2032 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698