Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h

Issue 2677223002: Distinguish between subresource filtering and dryrun matching. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h
diff --git a/third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h b/third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h
index 71e33d5ab77097072e3abe2b4ebe7bc6c19c6154..11b9ca7c7e04a9729843123cfc6d882536baf363 100644
--- a/third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h
+++ b/third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h
@@ -13,9 +13,11 @@ class WebURL;
class WebDocumentSubresourceFilter {
public:
+ enum LoadPolicy { Allow, Filter, AllowWouldFilter };
engedy 2017/02/06 16:56:32 nit: I find the term `filter` somewhat ambiguous:
Bryan McQuade 2017/02/06 17:11:56 Good suggestion, thanks! Updated to Allow/Disallow
virtual ~WebDocumentSubresourceFilter() {}
- virtual bool allowLoad(const WebURL& resourceUrl,
- WebURLRequest::RequestContext) = 0;
+ virtual LoadPolicy getLoadPolicy(const WebURL& resourceUrl,
+ WebURLRequest::RequestContext) = 0;
+ virtual void reportFilteredLoad() = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698