Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: src/heap/store-buffer.cc

Issue 2677163002: [heap] Add debug code for investigating store buffer crasher. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/store-buffer.cc
diff --git a/src/heap/store-buffer.cc b/src/heap/store-buffer.cc
index 2e5f720c9f78f4c312f56736b0e6e30ab6a56c64..5f21dbd753bc66db42463a4e112ccc40081e3f31 100644
--- a/src/heap/store-buffer.cc
+++ b/src/heap/store-buffer.cc
@@ -101,7 +101,10 @@ void StoreBuffer::MoveEntriesToRememberedSet(int index) {
DCHECK_LT(index, kStoreBuffers);
for (Address* current = start_[index]; current < lazy_top_[index];
current++) {
- DCHECK(!heap_->code_space()->Contains(*current));
+ CHECK(!heap_->code_space()->Contains(*current));
+ CHECK(heap_->old_space()->Contains(*current) ||
+ heap_->map_space()->Contains(*current) ||
+ heap_->lo_space()->ContainsSlow(*current));
Address addr = *current;
Page* page = Page::FromAnyPointerAddress(heap_, addr);
if (IsDeletionAddress(addr)) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698