node.cloneNode() should clone the value of file upload elements

Source/core/html/HTMLInputElement.cpp

Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index 7952c58f83be743b8803e9610ed433ab59f45558..e0439b5f52da059171a186e27f804133c37b5c4c 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -909,6 +909,8 @@ void HTMLInputElement::copyNonAttributePropertiesFromElement(const Element& sour
     setChecked(sourceElement.m_isChecked);
     m_reflectsCheckedAttribute = sourceElement.m_reflectsCheckedAttribute;
     m_isIndeterminate = sourceElement.m_isIndeterminate;
+    if (isFileUpload())
+        setFiles(sourceElement.files());

[Inactive, 2014/05/06 13:33:58]

Isn't it a problem that we are not actually cloning the FileList but merely
ref'ing it? You will then have 2 HTMLInputElement sharing the same FileList. Any
change to one HTMLInputElement's FileList will be reflected on the other
HTMLInputElement's FileList.

[gnana, 2014/05/07 12:39:46]

yes. I have modified to clone filelist.
Done.

 
     HTMLTextFormControlElement::copyNonAttributePropertiesFromElement(source);
 
@@ -1319,7 +1321,7 @@ KURL HTMLInputElement::src() const
     return document().completeURL(fastGetAttribute(srcAttr));
 }
 
-FileList* HTMLInputElement::files()
+FileList* HTMLInputElement::files() const
 {
     return m_inputType->files();
 }