LayoutTests/fast/forms/file/input-file-element-clone.html - Issue 267713006: node.cloneNode() should clone the value of file upload elements

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/file/input-file-element-clone.html

Issue 267713006: node.cloneNode() should clone the value of file upload elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../../../resources/js-test.js"></script>

	5 <script src="resources/file-drag-common.js"></script>

	6 <form method="GET">

	7 <input type="file" id="file1">

	8 </form>

	9 <script>

	10 description('Make sure that Node.cloneNode() works as expected for file input ty pe.');

	11 jsTestIsAsync = true;

	12 var file1 = document.getElementById('file1');

	13 file1.onchange = function() {

	14 var clone = file1.cloneNode(true);

	15 clone.id = "file2";

	16 document.body.appendChild(clone);

	17 var file2 = document.getElementById('file2');

	18 shouldBeEqualToString("file2.value", "C:\\fakepath\\input-file-element-clone .html");
	Inactive 2014/05/07 13:28:00 Would be nice if we would drag another file onto f Would be nice if we would drag another file onto file1 input and make sure that file2.value does not change (but file1.value changes). Since your first patch had this issue, I think it makes sense to cover this in your layout test. gnana 2014/05/07 14:22:37 Done. Show quoted text On 2014/05/07 13:28:00, Chris Dumez wrote: > Would be nice if we would drag another file onto file1 input and make sure that > file2.value does not change (but file1.value changes). Since your first patch > had this issue, I think it makes sense to cover this in your layout test. Done.
	19 finishJSTest();

	20 };

	21 window.onload = function()

	22 {

	23 dragFilesOntoInput(file1, ['input-file-element-clone.html']);

	24 }

	25 </script>

	26 </body>

	27 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/file/input-file-element-clone-expected.txt » ('j') | Source/core/html/HTMLInputElement.cpp » ('J')