Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 267703003: Logout all accounts from cookie jar when disconnecting from chrome. (Closed)

Created:
6 years, 7 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 7 months ago
Reviewers:
acleung1, guohui
CC:
chromium-reviews
Visibility:
Public.

Description

Logout all accounts from cookie jar when disconnecting from chrome. BUG=348531 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269672

Patch Set 1 #

Patch Set 2 : Fix signedout #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Patch Set 6 : rebased #

Patch Set 7 : rebased #

Patch Set 8 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/signin/account_reconcilor_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Alan, Please take a look. I have not yet tried this on android, will ...
6 years, 7 months ago (2014-05-01 16:02:43 UTC) #1
acleung1
lgtm
6 years, 7 months ago (2014-05-01 19:52:09 UTC) #2
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 7 months ago (2014-05-05 18:33:16 UTC) #3
Roger Tawa OOO till Jul 10th
The CQ bit was unchecked by rogerta@chromium.org
6 years, 7 months ago (2014-05-05 18:33:38 UTC) #4
Roger Tawa OOO till Jul 10th
Hi Hui, Can you take a look? Thanks.
6 years, 7 months ago (2014-05-07 23:53:37 UTC) #5
guohui
lgtm sorry for the delay, somehow missed it ...
6 years, 7 months ago (2014-05-08 16:01:31 UTC) #6
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 7 months ago (2014-05-10 04:09:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/267703003/200001
6 years, 7 months ago (2014-05-10 04:11:00 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 05:29:54 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 05:33:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67002)
6 years, 7 months ago (2014-05-10 05:33:29 UTC) #11
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 7 months ago (2014-05-10 22:24:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/267703003/200001
6 years, 7 months ago (2014-05-10 22:24:53 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:17:12 UTC) #14
Message was sent while issue was closed.
Change committed as 269672

Powered by Google App Engine
This is Rietveld 408576698