Add picture related attributes to Source

Add picture related attributes to Source

As part of the picture specification, the source element gets added with several new attributes, that are used in HTMLImageElement's source selection algorithm.
This CL adds these attributes.

BUG=368830
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173727

[eseidel, 2014-05-08 18:51:52]

We don't have a way to autogen these getAttribute calls these days?

Also I suspect you want fastGetAttribute. :)

[Nils Barth (inactive), 2014-05-09 01:54:59]

On 2014/05/08 18:51:52, eseidel wrote:
> We don't have a way to autogen these getAttribute calls these days?
> 
> Also I suspect you want fastGetAttribute. :)

Eric is correct: you don't need these wrapper methods if these attributes are
only being used from JavaScript,
as the bindings generate inline calls.
(The existing type(), setSrc(), and setType() are needed b/c you're using these
from C++)

This is potentially confusing ([Reflect] is the one case where you don't
(usually!) need a getter/setter), so I've documented it:
http://www.chromium.org/developers/web-idl-interfaces#TOC-C-

[Nils Barth (inactive), 2014-05-09 01:56:25]

https://codereview.chromium.org/267693002/diff/20001/Source/core/html/HTMLSou...
File Source/core/html/HTMLSourceElement.h (right):

https://codereview.chromium.org/267693002/diff/20001/Source/core/html/HTMLSou...
Source/core/html/HTMLSourceElement.h:43: const AtomicString& media() const;
As noted, not needed if only using from JavaScript.
I'd suggest only adding these if and when you access them from C++ (avoid dead
code).

[Yoav Weiss, 2014-05-09 05:21:09]

On 2014/05/09 01:56:25, Nils Barth wrote:
>
https://codereview.chromium.org/267693002/diff/20001/Source/core/html/HTMLSou...
> File Source/core/html/HTMLSourceElement.h (right):
> 
>
https://codereview.chromium.org/267693002/diff/20001/Source/core/html/HTMLSou...
> Source/core/html/HTMLSourceElement.h:43: const AtomicString& media() const;
> As noted, not needed if only using from JavaScript.
> I'd suggest only adding these if and when you access them from C++ (avoid dead
> code).

I've removed the getters. I'll probably need them in subsequent patches, but
adding them here was premature.
I'll add them as needed.

[eseidel, 2014-05-09 05:24:16]

lgtm

[commit-bot: I haz the power, 2014-05-09 05:25:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoav@yoav.ws/267693002/40001

[Nils Barth (inactive), 2014-05-09 05:26:13]

On 2014/05/09 05:21:09, Yoav Weiss wrote:
> I've removed the getters. I'll probably need them in subsequent patches, but
> adding them here was premature.
> I'll add them as needed.

Thanks, LGTM!

[commit-bot: I haz the power, 2014-05-09 06:31:17]

Change committed as 173727