third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp - Issue 2676923002: End-to-end prototype of compositor scrolling with slimming paint v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2676923002: End-to-end prototype of compositor scrolling with slimming paint v2 (Closed)

Patch Set: Add SPV2 test of didScroll callback Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

index 445c595b44494fdbe577d5a7e7666be82f5e91ef..7cc9535ab8be17f27c472e1a498b11ff769b7e65 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

@@ -751,7 +751,7 @@ void PaintPropertyTreeBuilder::updateScrollAndScrollTranslation(

bool scrollNodeNeededForMainThreadReasons = ancestorReasons != reasons;

const LayoutBox& box = toLayoutBox(object);

- const auto* scrollableArea = box.getScrollableArea();

+ auto* scrollableArea = box.getScrollableArea();

IntSize scrollOffset = box.scrolledContentOffset();

if (scrollNodeNeededForMainThreadReasons || !scrollOffset.isZero() ||

scrollableArea->scrollsOverflow()) {