third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html - Issue 2676873002: Convert Panner Audit tsets to testharness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

Issue 2676873002: Convert Panner Audit tsets to testharness (Closed)

Patch Set: Remove finish task and some extra blank lines Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-position-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html b/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

index cfc417944f22549a31ad9faa91cc0bebf9126c0e..77b97495838e18de7de3af6bc7eeec1b8a5f62d7 100644

--- a/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

+++ b/third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html

@@ -2,16 +2,14 @@

<html>

<head>

- <script src="../../resources/js-test.js"></script>

+ <script src="../../resources/testharness.js"></script>

+ <script src="../../resources/testharnessreport.js"></script>

</head>

<body>

- description("Basic tests for PannerNode.");

- window.jsTestIsAsync = true;

var context;

var panner;

var audit = Audit.createTaskRunner();

@@ -77,10 +75,8 @@

success = Should("panner.orientationZ", panner.orientationZ.value)

.beEqualTo(0) && success;

- if (success)

- testPassed("Basic Panner attribute tests.\n");

- else

- testFailed("Basic Panner attribute tests.\n");

+ Should("Basic Panner attribute tests", success)

+ .summarize("passed", "failed");

done();

});

@@ -107,10 +103,8 @@

success = Should("listener.upZ", context.listener.upZ.value)

.beEqualTo(0) && success;

- if (success)

- testPassed("Basic AudioListener attribute tests.\n");

- else

- testFailed("Basic AudioListener attribute tests.\n");

+ Should("Basic AudioListener attribute tests", success)

+ .summarize("passed", "failed");

done();

});

@@ -145,10 +139,8 @@

success = Should('panner.panningModel', panner.panningModel)

.beEqualTo("HRTF") && success;

- if (success)

- testPassed("Basic Panner panning models tests.\n");

- else

- testFailed("Basic Panner panning models tests.\n");

+ Should("Basic Panner panning models tests", success)

+ .summarize("passed", "failed");

done();

});

@@ -175,19 +167,11 @@

success = Should("panner.distanceModel", panner.distanceModel)

.beEqualTo("exponential") && success;

- if (success)

- testPassed("Basic Panner distance models tests.\n");

- else

- testFailed("Basic Panner distance models tests.\n");

+ Should("Basic Panner distance models tests", success)

+ .summarize("passed", "failed");

done();

});

- audit.defineTask("finish", function (done) {

- finishJSTest();

- done();

- });

audit.runTasks();

</script>