Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4189)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2676863002: Update WebApkInstaller to support badge icon in installation. (Closed)
Patch Set: addressing comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 7016833f23c203ae5fbf15868cddb5de041c3798..3c2bf84b619a054868f44941e3bc120bbe56585d 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -267,7 +267,7 @@ void AppBannerManager::OnDidPerformInstallableCheck(
DCHECK(data.primary_icon);
primary_icon_url_ = data.primary_icon_url;
- primary_icon_.reset(new SkBitmap(*data.primary_icon));
+ primary_icon_ = *data.primary_icon;
// If we triggered the installability check on page load, then it's possible
// we don't have enough engagement yet. If that's the case, return here but
@@ -540,7 +540,7 @@ void AppBannerManager::OnBannerPromptReply(
DCHECK(!manifest_url_.is_empty());
DCHECK(!manifest_.IsEmpty());
DCHECK(!primary_icon_url_.is_empty());
- DCHECK(primary_icon_.get());
+ DCHECK(!primary_icon_.drawsNothing());
TrackBeforeInstallEvent(BEFORE_INSTALL_EVENT_COMPLETE);
ShowBanner();
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698