chrome/browser/banners/app_banner_manager.h - Issue 2676863002: Update WebApkInstaller to support badge icon in installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2676863002: Update WebApkInstaller to support badge icon in installation. (Closed)

Patch Set: Addressing commentswq Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/banners/app_banner_manager.h

diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h

index 20d16a2dfd20be7711773637aabbfc87b0e7e971..487592fd18a86ea796ffaa7e2f0069dbf5e9f8d9 100644

--- a/chrome/browser/banners/app_banner_manager.h

+++ b/chrome/browser/banners/app_banner_manager.h

@@ -5,7 +5,6 @@

#ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_

#define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_

-#include <memory>

#include <vector>

#include "base/macros.h"

@@ -243,7 +242,7 @@ class AppBannerManager : public content::WebContentsObserver,

GURL primary_icon_url_;

// The primary icon object.

- std::unique_ptr<SkBitmap> primary_icon_;

+ SkBitmap primary_icon_;

// The referrer string (if any) specified in the app URL. Used only for native

// app banners.