Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: chrome/browser/android/webapk/webapk_install_service.cc

Issue 2676863002: Update WebApkInstaller to support badge icon in installation. (Closed)
Patch Set: Addressing comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_install_service.cc
diff --git a/chrome/browser/android/webapk/webapk_install_service.cc b/chrome/browser/android/webapk/webapk_install_service.cc
index 4319c03d4e9f95f95815c05d242b2ed98c142318..49c7b5da035a056052066384128ca390f0adc022 100644
--- a/chrome/browser/android/webapk/webapk_install_service.cc
+++ b/chrome/browser/android/webapk/webapk_install_service.cc
@@ -27,14 +27,15 @@ bool WebApkInstallService::IsInstallInProgress(const GURL& web_manifest_url) {
}
void WebApkInstallService::InstallAsync(const ShortcutInfo& shortcut_info,
- const SkBitmap& shortcut_icon,
+ const SkBitmap& primary_icon,
+ const SkBitmap& badge_icon,
const FinishCallback& finish_callback) {
DCHECK(!IsInstallInProgress(shortcut_info.manifest_url));
installs_.insert(shortcut_info.manifest_url);
WebApkInstaller::InstallAsync(
- browser_context_, shortcut_info, shortcut_icon,
+ browser_context_, shortcut_info, primary_icon, badge_icon,
base::Bind(&WebApkInstallService::OnFinishedInstall,
weak_ptr_factory_.GetWeakPtr(), shortcut_info.manifest_url,
finish_callback));

Powered by Google App Engine
This is Rietveld 408576698