Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2997)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 2676863002: Update WebApkInstaller to support badge icon in installation. (Closed)
Patch Set: Addressing comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 331c952a8bbfe9af987b6d483b2a5ce3de4f313e..43755d6dd1ba911a700f187325b2f8a50d08d026 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -33,18 +33,17 @@ class ShortcutHelper {
static bool RegisterShortcutHelper(JNIEnv* env);
// Adds a shortcut to the launcher using a SkBitmap. The type of shortcut
- // added depends on the properties in |info|. Calls one of
- // InstallWebApkInBackgroundWithSkBitmap, AddWebappInBackgroundWithSkBitmap,
- // or AddShortcutInBackgroundWithSkBitmap.
+ // added depends on the properties in |info|.
static void AddToLauncherWithSkBitmap(content::WebContents* web_contents,
const ShortcutInfo& info,
const SkBitmap& icon_bitmap);
// Installs WebAPK and adds shortcut to the launcher.
static void InstallWebApkWithSkBitmap(
- content::WebContents* web_conetnts,
+ content::WebContents* web_contents,
const ShortcutInfo& info,
- const SkBitmap& icon_bitmap,
+ const SkBitmap& primary_icon_bitmap,
+ const SkBitmap& badge_icon_bitmap,
const WebApkInstallService::FinishCallback& callback);
// Shows toast notifying user that a WebAPK install is already in progress
@@ -70,8 +69,8 @@ class ShortcutHelper {
// Fetches the splash screen image and stores it inside the WebappDataStorage
// of the webapp. The WebappDataStorage object *must* have been previously
- // created by |AddShortcutInBackgroundWithSkBitmap|; this method should be
- // passed as a closure to that method.
+ // created by AddToLauncherWithSkBitmap(); this method should be passed as a
+ // closure to that method.
static void FetchSplashScreenImage(content::WebContents* web_contents,
const GURL& image_url,
const int ideal_splash_image_size_in_px,

Powered by Google App Engine
This is Rietveld 408576698