Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2676863002: Update WebApkInstaller to support badge icon in installation. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index a6d0f74cde0760acc9a47f841344ba24f87639af..7486fa999cbdd6153f05a6472d229c678b73a157 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -39,12 +39,14 @@ namespace {
std::unique_ptr<ShortcutInfo> CreateShortcutInfo(
const GURL& manifest_url,
const content::Manifest& manifest,
- const GURL& icon_url) {
+ const GURL& primary_icon_url,
+ const GURL& badge_icon_url) {
auto shortcut_info = base::MakeUnique<ShortcutInfo>(GURL());
if (!manifest.IsEmpty()) {
shortcut_info->UpdateFromManifest(manifest);
shortcut_info->manifest_url = manifest_url;
- shortcut_info->best_primary_icon_url = icon_url;
+ shortcut_info->best_primary_icon_url = primary_icon_url;
+ shortcut_info->best_badge_icon_url = badge_icon_url;
shortcut_info->UpdateSource(ShortcutInfo::SOURCE_APP_BANNER);
}
@@ -229,12 +231,12 @@ void AppBannerManagerAndroid::ShowBanner() {
DCHECK(contents);
if (native_app_data_.is_null()) {
- // TODO(zpeng): Add badge to WebAPK installation flow.
if (AppBannerInfoBarDelegateAndroid::Create(
contents, GetWeakPtr(), app_title_,
- CreateShortcutInfo(manifest_url_, manifest_, primary_icon_url_),
- std::move(primary_icon_), event_request_id(),
- webapk::INSTALL_SOURCE_BANNER)) {
+ CreateShortcutInfo(manifest_url_, manifest_, primary_icon_url_,
+ badge_icon_url_),
+ std::move(primary_icon_), std::move(badge_icon_),
+ event_request_id(), webapk::INSTALL_SOURCE_BANNER)) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);
ReportStatus(contents, SHOWING_WEB_APP_BANNER);

Powered by Google App Engine
This is Rietveld 408576698